From cc3ff42e08036e7eb6a2a91ff7796d9a179ccf81 Mon Sep 17 00:00:00 2001 From: Steve Bertrand Date: Tue, 1 Mar 2016 16:41:46 -0700 Subject: [PATCH 1/2] fixed issue in create_ping_object_not_ok() --- lib/Test/Ping.pm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/Test/Ping.pm b/lib/Test/Ping.pm index 7127d9e..3b6c08a 100755 --- a/lib/Test/Ping.pm +++ b/lib/Test/Ping.pm @@ -85,9 +85,11 @@ sub create_ping_object_not_ok { my @args = @_; my $name = pop @args || q{}; my $tb = $CLASS->builder; - $OBJPATH = Net::Ping->new(@args); + my $error; + eval { Net::Ping->new(@args); 1; } + or $error = $@; - $tb->ok( !$OBJPATH, $name ); + $tb->ok( $error, $name ); } sub _has_var_ok { From 68311a85aeb550e8883720eee1168a37c06265a9 Mon Sep 17 00:00:00 2001 From: Steve Bertrand Date: Tue, 1 Mar 2016 16:54:22 -0700 Subject: [PATCH 2/2] fixed issue in create_ping_object_ok() --- MANIFEST | 2 ++ lib/Test/Ping.pm | 9 +++------ 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/MANIFEST b/MANIFEST index f2aaa21..c5c0b5c 100644 --- a/MANIFEST +++ b/MANIFEST @@ -31,6 +31,8 @@ t/13-service.t t/14-ping_icmp.t t/15-ping_udp.t t/16-ties.t +t/17-ping_obj_not_ok.t +t/18-ping_obj_ok.t t/critic.t t/meta.t t/pod-coverage.t diff --git a/lib/Test/Ping.pm b/lib/Test/Ping.pm index 3b6c08a..9df4dc7 100755 --- a/lib/Test/Ping.pm +++ b/lib/Test/Ping.pm @@ -72,13 +72,10 @@ sub create_ping_object_ok { my @args = @_; my $name = pop @args || q{}; my $tb = $CLASS->builder; - $OBJPATH = Net::Ping->new(@args); - if ($OBJPATH) { - $tb->is_eq( ref $OBJPATH, 'Net::Ping', $name ); - } else { - $tb->ok( 0, $name ); - } + eval { $OBJPATH = Net::Ping->new(@args); }; + + $tb->is_eq( ref $OBJPATH, 'Net::Ping', $name ); } sub create_ping_object_not_ok {