Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XEP-0428: Fallback Indication v0.2.0 #1188

Merged
merged 2 commits into from Mar 31, 2023
Merged

XEP-0428: Fallback Indication v0.2.0 #1188

merged 2 commits into from Mar 31, 2023

Conversation

mar-v-in
Copy link
Contributor

@mar-v-in mar-v-in commented Jul 17, 2022

This incorporates most of the ideas of the "Compatibility Fallback" ProtoXEP as discussed in the council chat room back then.

  • Add 'for' attribute such that entities can discover what the fallback is for.
  • Allow to specify that only one of <subject/> or <body/> is meant as a fallback.
  • Allow to specify the part of respective text that is meant as fallback where applicable.
  • Don't use encryption example, which should use XEP-0380 instead.

@mar-v-in
Copy link
Contributor Author

@dwd

@cal0pteryx
Copy link
Member

@mar-v-in congratulations on taking co-authorship on XEP-0428! I'd love to see this move forward, especially in conjunction with XEP-0461: Message Replies 👍

- Add 'for' attribute such that entities can discover what the fallback is for.
- Allow to specify that only one of <subject/> or <body/> is meant as a fallback.
- Allow to specify the part of respective text that is meant as fallback where applicable.
- Don't use encryption example, which should use XEP-0380 instead.
@singpolyma
Copy link
Contributor

Is end intended to be inclusive or exclusive? By the example provided it seems exclusive, but the normative text should indicate one way or the other IMHO.

@mar-v-in
Copy link
Contributor Author

mar-v-in commented Dec 27, 2022

@singpolyma I'll add that to XEP-0426 instead (as it should be a general convention and not specific to this XEP). (#1260)

@mar-v-in
Copy link
Contributor Author

mar-v-in commented Jan 7, 2023

Note to editors: This can be merged.

@Kev Kev added the Ready To Merge No acknowledgements of other parties are needed anymore. There may be changes to do at merge time. label Jan 30, 2023
xep-0428.xml Outdated
<p>The fallback indicator is an element <tt>&lt;fallback/></tt> qualified by the <tt>&ns;</tt> namespace. It has no
attributes, content, or child elements.</p>
<p>The fallback indicator is an element <tt>&lt;fallback/></tt> qualified by the <tt>&ns;</tt> namespace. It has an attribute
<tt>for</tt> that indidcates the specification that the fallback is meant to replace. This is typically the primary namespace
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indidcates → indicates

@Kev Kev merged commit 186c69b into xsf:master Mar 31, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready To Merge No acknowledgements of other parties are needed anymore. There may be changes to do at merge time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants