New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XEP-0367: Update to specify the correct ID to use within MUCs #696

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@mwild1
Contributor

mwild1 commented Aug 18, 2018

The current version of the XEP currently only uses the 'id' attribute, which is a namespace shared by all clients in a MUC, leading to collisions and race conditions.

This update switches it to use the stanza-id assigned to the message by the MUC.

@SamWhited

This comment has been minimized.

Member

SamWhited commented Aug 18, 2018

LGTM

Clients that implement message attachments MUST display the attachments
in such a way that they could be confused with the original message and
cause someone viewing the conversation to assume they were sent by the
sender of the message being attached to.

This comment has been minimized.

@jcbrand

jcbrand Aug 30, 2018

Contributor

@mwild1 Is there a "not" missing here?

I.e. "in such a way that they could NOT be confused with the original message"

CC @SamWhited

@jcbrand jcbrand added the question label Aug 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment