XEP-0367: Update to specify the correct ID to use within MUCs #696
Conversation
|
LGTM |
xep-0367.xml
Outdated
| Clients that implement message attachments MUST display the attachments | ||
| in such a way that they could be confused with the original message and | ||
| cause someone viewing the conversation to assume they were sent by the | ||
| sender of the message being attached to. |
jcbrand
Aug 30, 2018
•
Contributor
@mwild1 Is there a "not" missing here?
I.e. "in such a way that they could NOT be confused with the original message"
CC @SamWhited
@mwild1 Is there a "not" missing here?
I.e. "in such a way that they could NOT be confused with the original message"
CC @SamWhited
mwild1
Jan 10, 2019
Author
Contributor
@jcbrand @SamWhited Ha, sorry for the late response. Yes, obviously there is a 'not' missing :)
@jcbrand @SamWhited Ha, sorry for the late response. Yes, obviously there is a 'not' missing :)
|
You may want to consider adding XEP-0359 to the dependencies meta information: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The current version of the XEP currently only uses the 'id' attribute, which is a namespace shared by all clients in a MUC, leading to collisions and race conditions.
This update switches it to use the stanza-id assigned to the message by the MUC.