Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XEP-0367: Update to specify the correct ID to use within MUCs #696

Merged
merged 4 commits into from Jan 13, 2019

Conversation

@mwild1
Copy link
Contributor

@mwild1 mwild1 commented Aug 18, 2018

The current version of the XEP currently only uses the 'id' attribute, which is a namespace shared by all clients in a MUC, leading to collisions and race conditions.

This update switches it to use the stanza-id assigned to the message by the MUC.

@SamWhited
Copy link
Contributor

@SamWhited SamWhited commented Aug 18, 2018

LGTM

Clients that implement message attachments MUST display the attachments
in such a way that they could be confused with the original message and
cause someone viewing the conversation to assume they were sent by the
sender of the message being attached to.

This comment has been minimized.

@jcbrand

jcbrand Aug 30, 2018
Contributor

@mwild1 Is there a "not" missing here?

I.e. "in such a way that they could NOT be confused with the original message"

CC @SamWhited

This comment has been minimized.

@mwild1

mwild1 Jan 10, 2019
Author Contributor

@jcbrand @SamWhited Ha, sorry for the late response. Yes, obviously there is a 'not' missing :)

@Flowdalic
Copy link
Contributor

@Flowdalic Flowdalic commented Jan 10, 2019

You may want to consider adding XEP-0359 to the dependencies meta information:

  <dependencies>
    <spec>XMPP Core</spec>
  </dependencies>
@horazont horazont removed the question label Jan 13, 2019
@horazont horazont merged commit 0edd42a into xsf:master Jan 13, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants