Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upXEP-0367: Update to specify the correct ID to use within MUCs #696
Conversation
This comment has been minimized.
This comment has been minimized.
|
LGTM |
mwild1
referenced this pull request
Aug 28, 2018
Open
URL previews via XEP-0367: Message Attaching #1173
| Clients that implement message attachments MUST display the attachments | ||
| in such a way that they could be confused with the original message and | ||
| cause someone viewing the conversation to assume they were sent by the | ||
| sender of the message being attached to. |
This comment has been minimized.
This comment has been minimized.
jcbrand
Aug 30, 2018
•
Contributor
@mwild1 Is there a "not" missing here?
I.e. "in such a way that they could NOT be confused with the original message"
CC @SamWhited
jcbrand
added
the
question
label
Aug 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
mwild1 commentedAug 18, 2018
The current version of the XEP currently only uses the 'id' attribute, which is a namespace shared by all clients in a MUC, leading to collisions and race conditions.
This update switches it to use the stanza-id assigned to the message by the MUC.