Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XEP-0384: Add message counter logic to determine stale devices #709

Open
wants to merge 3 commits into
base: master
from

Conversation

@vanitasvitae
Copy link
Contributor

vanitasvitae commented Oct 8, 2018

This PR adds a business rule that helps to determine stale/inactive devices and specifies a way to deal with them.

This is a fix for a protocol vulnerability which might lead to loss of forward secrecy.

Wording might be subject to change :)

vanitasvitae added 3 commits Oct 8, 2018
@vanitasvitae

This comment has been minimized.

Copy link
Contributor Author

vanitasvitae commented Oct 10, 2018

I changed the wording a bit to exclude "ping messages" from incrementing the counter. That way a device which is overdoing ratchet forwarding by sending lots of ping messages will not consider peer devices as read-only prematurely.

@horazont horazont changed the title Add message counter logic to determine stale devices XEP-0384: Add message counter logic to determine stale devices Nov 3, 2018
@horazont horazont self-assigned this Nov 3, 2018
@horazont

This comment has been minimized.

Copy link
Contributor

horazont commented Nov 3, 2018

@strb Please comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.