Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix t/010_internals/008_files.t #206

Merged
merged 1 commit into from Oct 31, 2021
Merged

fix t/010_internals/008_files.t #206

merged 1 commit into from Oct 31, 2021

Conversation

skaji
Copy link
Member

@skaji skaji commented Oct 30, 2021

https://www.cpantesters.org/cpan/report/694c1696-3809-11ec-8d11-e947f7ad8bd4

    #   Failed test 'auto reload 1'
    #   at t/010_internals/008_files.t line 74.
    #          got: 'Hello, Perl world!
    # '
    #     expected: 'Hi, Perl.
    # '

    #   Failed test 'auto reload 2'
    #   at t/010_internals/008_files.t line 74.
    #          got: 'Hello, Perl world!
    # '
    #     expected: 'Hi, Perl.
    # '
    # Looks like you failed 2 tests of 3.

#   Failed test 'cache => 1 (default mode)'
#   at t/010_internals/008_files.t line 75.
# Looks like you failed 1 test of 3.
t/010_internals/008_files.t ..................... 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/3 subtests 

Currently we use $^T + 10 to update file modification time,
but if the test take a lot of time for some reasons, then $^T + 10 may not update file modification time.

Use time + 10 to make sure we update file modification time.

@skaji skaji merged commit 40313bd into master Oct 31, 2021
@skaji skaji deleted the fix-test branch October 31, 2021 00:52
@skaji
Copy link
Member Author

skaji commented Oct 31, 2021

@syohex Thanks!

skaji added a commit that referenced this pull request Oct 31, 2021
Changelog diff is:

diff --git a/Changes b/Changes
index 94faa158..9c553e91 100644
--- a/Changes
+++ b/Changes
@@ -2,6 +2,9 @@ Revision history for Perl extension Text::Xslate
 
 {{$NEXT}}
 
+v3.5.9 2021-10-31T01:10:44Z
+    - Fix t/010_internals/008_files.t (#206)
+
 v3.5.8 2020-06-01T15:17:51Z
     - Fix "Argument list too long" in test (greeneg #202, #203, #204)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants