diff --git a/Packs/FireEyeNX/.pack-ignore b/Packs/FireEyeNX/.pack-ignore index 79cc0a7e141c..a3854dcc175a 100644 --- a/Packs/FireEyeNX/.pack-ignore +++ b/Packs/FireEyeNX/.pack-ignore @@ -71,4 +71,7 @@ ignore=RM104 ignore=BA101 [file:classifier-FireEye_NX.json] -ignore=BA101 \ No newline at end of file +ignore=BA101 + +[known_words] +NX \ No newline at end of file diff --git a/Packs/FireEyeNX/Integrations/FireEyeNX/FireEyeNX.py b/Packs/FireEyeNX/Integrations/FireEyeNX/FireEyeNX.py index a64e492f6055..8ede6d0b1b9b 100644 --- a/Packs/FireEyeNX/Integrations/FireEyeNX/FireEyeNX.py +++ b/Packs/FireEyeNX/Integrations/FireEyeNX/FireEyeNX.py @@ -220,13 +220,12 @@ def is_supported_context_type(content_type: str): :param content_type: content type of header. :return: boolean flag, whether content type is supported or not. """ - if ( + return ( content_type == 'application/pdf' or content_type == 'text/csv' or content_type == CONTENT_TYPE_ZIP - ): - return True - return False + or content_type == 'application/octet-stream' + ) @staticmethod def handle_demisto_exception(e): @@ -1166,7 +1165,7 @@ def get_artifacts_by_alert_command( # Preparing header headers = { - 'accept': CONTENT_TYPE_ZIP, + 'Content-Type': CONTENT_TYPE_ZIP, 'X-FeApi-Token': client.get_api_token(), } diff --git a/Packs/FireEyeNX/Integrations/FireEyeNX/FireEyeNX.yml b/Packs/FireEyeNX/Integrations/FireEyeNX/FireEyeNX.yml index e631236774fe..c4910f8b3443 100644 --- a/Packs/FireEyeNX/Integrations/FireEyeNX/FireEyeNX.yml +++ b/Packs/FireEyeNX/Integrations/FireEyeNX/FireEyeNX.yml @@ -1254,7 +1254,7 @@ script: - contextPath: FireEyeNX.Event.IncidentId description: The incident ID of the event on FireEye. type: Number - dockerimage: demisto/python3:3.10.8.37753 + dockerimage: demisto/python3:3.10.10.47713 feed: false isfetch: true longRunning: false diff --git a/Packs/FireEyeNX/Integrations/FireEyeNX/FireEyeNX_test.py b/Packs/FireEyeNX/Integrations/FireEyeNX/FireEyeNX_test.py index 7d83cd17f80d..5968297d32ef 100644 --- a/Packs/FireEyeNX/Integrations/FireEyeNX/FireEyeNX_test.py +++ b/Packs/FireEyeNX/Integrations/FireEyeNX/FireEyeNX_test.py @@ -1026,16 +1026,25 @@ def test_is_supported_context_type_failure(client): """ When is_supported_context_type() method called invalid argument then should return False. """ - assert ( - client.is_supported_context_type('application/octet-stream') is False + assert not ( + client.is_supported_context_type('image/png') ) -def test_is_supported_context_type_success(client): +@pytest.mark.parametrize( + 'context_type', + [ + CONTENT_TYPE_ZIP, + "text/csv", + "application/pdf", + 'application/octet-stream' + ] +) +def test_is_supported_context_type_success(client, context_type): """ When is_supported_context_type() method called valid argument then should return True. """ - assert client.is_supported_context_type(CONTENT_TYPE_ZIP) is True + assert client.is_supported_context_type(context_type) @patch('FireEyeNX.Client.http_request') diff --git a/Packs/FireEyeNX/ReleaseNotes/1_1_10.md b/Packs/FireEyeNX/ReleaseNotes/1_1_10.md index f90706a3a940..60bd18c872b3 100644 --- a/Packs/FireEyeNX/ReleaseNotes/1_1_10.md +++ b/Packs/FireEyeNX/ReleaseNotes/1_1_10.md @@ -1,10 +1,3 @@ -<<<<<<< HEAD -#### Parsing Rules -##### New: FireEyeNX Parsing Rule -- Added parsing rule for _time extraction (Available from Cortex XSOAR 6.10.0). -======= - #### Modeling Rules ##### FireEye NX Modeling Rule - Fixed invalid types in schema file. ->>>>>>> master diff --git a/Packs/FireEyeNX/ReleaseNotes/1_1_14.md b/Packs/FireEyeNX/ReleaseNotes/1_1_14.md new file mode 100644 index 000000000000..f6d264d40fee --- /dev/null +++ b/Packs/FireEyeNX/ReleaseNotes/1_1_14.md @@ -0,0 +1,4 @@ +#### Integrations +##### FireEye NX +- Fixed an issue where the ***fireeye-nx-get-artifacts-by-alert*** command did not work. +- Updated the Docker image to: *demisto/python3:3.10.10.47713*. \ No newline at end of file diff --git a/Packs/FireEyeNX/pack_metadata.json b/Packs/FireEyeNX/pack_metadata.json index 1b3d04cdf053..0f67cff22356 100644 --- a/Packs/FireEyeNX/pack_metadata.json +++ b/Packs/FireEyeNX/pack_metadata.json @@ -2,7 +2,7 @@ "name": "FireEye Network Security (NX)", "description": "FireEye Network Security is an effective cyber threat protection solution that helps organizations minimize the risk of costly breaches by accurately detecting and immediately stopping advanced, targeted, and other evasive attacks hiding in Internet traffic.", "support": "xsoar", - "currentVersion": "1.1.13", + "currentVersion": "1.1.14", "author": "Cortex XSOAR", "url": "https://www.paloaltonetworks.com/cortex", "email": "",