Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(report): report x:expect/attribute(test) separetely in report XML #1109

Merged
merged 4 commits into from
Jul 27, 2020

Conversation

AirQuick
Copy link
Member

@AirQuick AirQuick commented Jul 25, 2020

x:expect/@test and the content of x:expect/@href require different sets of namespaces. But the test result report XML reports them in a single x:expect, which is not possible.
This pull request fixes it by reporting @test in another element.

@AirQuick AirQuick added the bug label Jul 25, 2020
@AirQuick AirQuick added this to the v2.0 milestone Jul 25, 2020
# Conflicts:
#	src/compiler/generate-query-tests.xsl
#	src/compiler/generate-xspec-tests.xsl
#	test/end-to-end/cases/expected/query/ambiguous-expect-result.xml
#	test/end-to-end/cases/expected/query/focus-1-result.xml
#	test/end-to-end/cases/expected/query/function-result.xml
#	test/end-to-end/cases/expected/query/import-result.xml
#	test/end-to-end/cases/expected/query/issue-151-result.xml
#	test/end-to-end/cases/expected/query/issue-153-result.xml
#	test/end-to-end/cases/expected/query/issue-177-result.xml
#	test/end-to-end/cases/expected/query/issue-450-451-result.xml
#	test/end-to-end/cases/expected/query/label-element-result.xml
#	test/end-to-end/cases/expected/query/pending-result.xml
#	test/end-to-end/cases/expected/query/serialize-result.xml
#	test/end-to-end/cases/expected/query/shared-like-result.xml
#	test/end-to-end/cases/expected/schematron/issue-693-result.xml
#	test/end-to-end/cases/expected/schematron/label-element-result.xml
#	test/end-to-end/cases/expected/schematron/schematron-023-result.xml
#	test/end-to-end/cases/expected/schematron/schematron-import_demo-02-PhaseB-result.xml
#	test/end-to-end/cases/expected/schematron/tvt_label_schematron-result.xml
#	test/end-to-end/cases/expected/stylesheet/ambiguous-expect-result.xml
#	test/end-to-end/cases/expected/stylesheet/focus-1-result.xml
#	test/end-to-end/cases/expected/stylesheet/format-xspec-report-folding-result.xml
#	test/end-to-end/cases/expected/stylesheet/function-result.xml
#	test/end-to-end/cases/expected/stylesheet/import-result.xml
#	test/end-to-end/cases/expected/stylesheet/issue-151-result.xml
#	test/end-to-end/cases/expected/stylesheet/issue-153-result.xml
#	test/end-to-end/cases/expected/stylesheet/issue-177-result.xml
#	test/end-to-end/cases/expected/stylesheet/issue-450-451-result.xml
#	test/end-to-end/cases/expected/stylesheet/label-element-result.xml
#	test/end-to-end/cases/expected/stylesheet/pending-result.xml
#	test/end-to-end/cases/expected/stylesheet/result-naming-collision-result.xml
#	test/end-to-end/cases/expected/stylesheet/serialize-result.xml
#	test/end-to-end/cases/expected/stylesheet/shared-like-result.xml
#	test/end-to-end/cases/expected/stylesheet/xslt2-result.xml
@AirQuick AirQuick merged commit 177b06c into xspec:master Jul 27, 2020
@AirQuick AirQuick deleted the separate-report-test-attr branch July 27, 2020 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant