-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pending variable declarations #1452
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worthwhile to have tests similar to the ones you have, except that the variables and parameters are defined inside shared scenarios and referenced using x:like
? It would show that the inheritance logic accounts for resolution of x:like
instead of being based only on the original XSpec document's tree structure. If you'd like me to create those variations (in a separate PR because I don't think I know how to add files to someone else's PR), let me know.
Good point. I didn't think about that. Can you create them? |
Sure, I'll do that. |
Imitate tests from PR xspec#1452, except that the variables and parameters are defined inside shared scenarios and referenced using x:like. Shows that the inheritance logic accounts for resolution of x:like instead of being based only on the original XSpec document's tree structure.
In response to #1415 (comment), this pull request changes how
x:variable
andx:param[parent::x:scenario]
in a pending scenario are handled: