Rename test:report-value to report-sequence or report-node #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st-file-format # Conflicts: # test/xspec-bat.cmd # test/xspec.bats
…185_cumulative # Conflicts: # test/xspec.bats
This reverts commit 3de253c.
# Conflicts: # test/generate-x-utils.xspec
…result-naming-collision_label # Conflicts: # bin/xspec.sh # java/com/jenitennison/xslt/tests/XSLTCoverageTraceListener.class # java/com/jenitennison/xslt/tests/XSLTCoverageTraceListener.java # test/end-to-end/processor/junit/_normalizer.xsl # test/end-to-end/processor/xml/_normalizer.xsl # test/win-bats/collection.xml # test/xspec-space_stylesheet.xspec # test/xspec.bats
…-result-naming-collision_e2e
|
@cirulls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request derives from #377. So needs to be handled after that.
test:report-valuehas some fundamental issues. And it has too vague naming convention. It calls everything value.So it is unclear whether a particular code line is handling a sequence (of possibly multiple various items) or nodes or atomic values. I guess that such naming convention might have contributed to the issues.
This pull request renames
test:report-valuetoreport-sequenceorreport-nodeaccordingly and renames their parameters to better reflect their nature.This change makes it easier to fix the bugs of the report feature.