Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Schematron template for Oxygen #745

Merged
merged 3 commits into from
Nov 29, 2019
Merged

Conversation

AirQuick
Copy link
Member

Like #737, this pull request adds an Oxygen template for Schematron XSpec.

Compared to the Oxygen 21.1's built-in template, this template is simplified and a little bit more focused on being a template than being a tutorial.

This template has the same name (Schematron Unit Test) as the Oxygen 21.1's built-in template in New Document. On Oxygen 21.1, the built-in one is a static template which does not have a custom dialog, so I think this pull request can just replace the built-in one. (On the other hand, the built-in XSLT Unit Test has a custom dialog. We can't replace it with a static template.)
If the situation remains unchanged on the next version of Oxygen, I would like SyncRO Soft to take this XSpec framework and remove the built-in one on the next version of Oxygen to avoid duplication.

@AirQuick AirQuick added this to the v1.5.0 milestone Nov 26, 2019
@AirQuick AirQuick requested a review from a team November 26, 2019 13:42
Copy link
Member

@galtm galtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. My only comment is very minor.

templates/schematron.xspec Outdated Show resolved Hide resolved
@AirQuick AirQuick merged commit ce56c7a into xspec:master Nov 29, 2019
@AirQuick AirQuick deleted the oxy-sch-tmpl branch November 29, 2019 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants