Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust the rsqrt error range to account for AMD hardware #757

Closed
amyspark opened this issue May 30, 2022 · 1 comment · Fixed by #790
Closed

Adjust the rsqrt error range to account for AMD hardware #757

amyspark opened this issue May 30, 2022 · 1 comment · Fixed by #790

Comments

@amyspark
Copy link
Contributor

@serge-sans-paille @JohanMabille,

I reported a possible miscodegen error in test_rsqrt to Microsoft here. Turns out, AMD has slight precision issues wrt. Intel, so the test will fail with off-by-one errors for certain inputs.

Would it be possible to set an error range like it's done for the gamma function under AppleClang?
@serge-sans-paille
Copy link
Contributor

Sure! Would you mind proposing a patch?

amyspark added a commit to amyspark/xsimd that referenced this issue Jul 19, 2022
@amyspark
rsqrt: account for AMD vs. Intel inconsistency in RCPPS relative error
45d8a32 
Fixes xtensor-stack#757
amyspark added a commit to amyspark/xsimd that referenced this issue Jul 19, 2022
@amyspark
rsqrt: account for AMD vs. Intel inconsistency in RCPPS relative error
8664f7c 
Fixes xtensor-stack#757
@amyspark amyspark mentioned this issue Jul 19, 2022
Merged
amyspark added a commit to amyspark/xsimd that referenced this issue Jul 19, 2022
@amyspark
rsqrt: account for AMD vs. Intel inconsistency in RCPPS relative error
fc28fc4 
Fixes xtensor-stack#757
serge-sans-paille pushed a commit that referenced this issue Jul 19, 2022
@amyspark @serge-sans-paille
rsqrt: account for AMD vs. Intel inconsistency in RCPPS relative error
e06d460 
Fixes #757
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rsqrt: account for AMD vs. Intel inconsistency in RCPPS relative error amyspark/xsimd
2 participants
@serge-sans-paille @amyspark