FixAVX 512 build under VS2015 #451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serge-sans-paille
force-pushed
the
feature/test-avx512-vs2015
branch
5 times, most recently
from
db45e80 to
414b017
Compare
serge-sans-paille
force-pushed
the
feature/test-avx512-vs2015
branch
from
414b017 to
b6dd639
Compare
serge-sans-paille
changed the title
serge-sans-paille
force-pushed
the
feature/test-avx512-vs2015
branch
19 times, most recently
from
14cfa1b to
9d4e6d5
Compare
Member
|
🎉 |
MSVC doesn't ship them, and it's uncleanr whether they are officially required by Intel. https://software.intel.com/sites/landingpage/IntrinsicsGuide/ don't list them.
serge-sans-paille
force-pushed
the
feature/test-avx512-vs2015
branch
13 times, most recently
from
c38678f to
8c21309
Compare
Downgrade to AVX2 when MSVC doesn't support the AVX512 builtin. This could be improved based on the compiler version, better safe than sorry here.
serge-sans-paille
force-pushed
the
feature/test-avx512-vs2015
branch
from
8c21309 to
52517c9
Compare
Contributor
Author
|
@JohanMabille green again! I feel like the green vador of AVX512 |
Member
|
Should we go ahead and merge this? |
Member
|
Not yet, @serge-sans-paille wants to test this implementation on Linux before merging it (or we can rebase this PR after the configuration with AVX512 on Windows is added). |
Member
|
serge-sans-paille
force-pushed
the
feature/test-avx512-vs2015
branch
3 times, most recently
from
9662e9c to
28e1b62
Compare
Contributor
Author
|
cc @JohanMabille 28e1b62 passes validation, which validates the AVX512 implementation fallbacks, according to me. |
Member
|
I confirm! |
serge-sans-paille
force-pushed
the
feature/test-avx512-vs2015
branch
from
28e1b62 to
52517c9
Compare
Member
|
Awesome! |
Contributor
|
This seems to have fixed our build issues. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #421