Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search addon does not search start of wrapped line when ydisp is in the middle of it #2325

Open
Tyriar opened this issue Jul 20, 2019 · 4 comments · May be fixed by #2520
Open

Search addon does not search start of wrapped line when ydisp is in the middle of it #2325

Tyriar opened this issue Jul 20, 2019 · 4 comments · May be fixed by #2520

Comments

@Tyriar
Copy link
Member

@Tyriar Tyriar commented Jul 20, 2019

Repro:

Write one really long wrapped line that spans multiple viewports
Search for a string above the viewport, no results will be found

@miggs125

This comment has been minimized.

Copy link
Contributor

@miggs125 miggs125 commented Oct 21, 2019

Mind if I give this issue a shot?

@Tyriar

This comment has been minimized.

Copy link
Member Author

@Tyriar Tyriar commented Oct 21, 2019

@miggs125 sure!

@miggs125

This comment has been minimized.

Copy link
Contributor

@miggs125 miggs125 commented Oct 26, 2019

@Tyriar I haven't been able to reproduce this bug, perhaps I am doing it wrong? I opened up the demo, ran ls and then filled the terminal with lorem ipsum until the results of ls weren't visible. I then searched for strings in the output of ls and it seems to be working.

@Tyriar

This comment has been minimized.

Copy link
Member Author

@Tyriar Tyriar commented Oct 26, 2019

@miggs125 that's the repro yeah, I can still get it to happen:

image

(vscode is basically at master of xterm atm)

Maybe tweak the width of the terminal or position of the string you're searching for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.