Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use IntersectionObserver to turn off renderer when hidden #1144

Merged
merged 4 commits into from
Jan 5, 2018
Merged

Use IntersectionObserver to turn off renderer when hidden #1144

merged 4 commits into from
Jan 5, 2018

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Dec 11, 2017

Fixes #880

@mofux seems to work nicely in Chrome, what do you think? This can save like 5ms a frame for heavy operations 🔥

@Tyriar Tyriar self-assigned this Dec 11, 2017
@Tyriar Tyriar requested a review from mofux December 11, 2017 23:17
@Tyriar
Copy link
Member Author

Tyriar commented Dec 11, 2017

Here's an annotated timeline of the change within VS Code doing the following:

  1. Open a terminal
  2. Run ls -lR in large folder
  3. Create new terminal (hide busy terminal)

image

To give an idea of the time saved, the draws on the busy terminal before the switch are about 5ms, 5ms and 2ms every available animation frame.

@Tyriar Tyriar added this to the 3.1.0 milestone Dec 11, 2017
@Tyriar Tyriar mentioned this pull request Dec 11, 2017
Closed
mofux
mofux approved these changes Dec 12, 2017
View reviewed changes
Copy link
Contributor

@mofux mofux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice and well written PR, I'm more happy to get this merged!

@Tyriar
Copy link
Member Author

Tyriar commented Dec 12, 2017

🎉 will wait until v3 is done before merging it in.

parisk
parisk approved these changes Dec 16, 2017
View reviewed changes
Copy link
Contributor

@parisk parisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍. Can't wait to see this in 3.1.

@Tyriar Tyriar changed the base branch from v3 to master January 5, 2018 16:26
@Tyriar
Copy link
Member Author

Tyriar commented Jan 5, 2018

Linux tests are passing, merging this in (mac agents are backed up)

@Tyriar Tyriar merged commit eac14a1 into xtermjs:master Jan 5, 2018
@Tyriar Tyriar deleted the 880_renderer_pause branch January 5, 2018 22:16
@chabou chabou mentioned this pull request Jan 15, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mofux mofux mofux approved these changes

@parisk parisk parisk approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Tyriar @parisk @mofux