Use IntersectionObserver to turn off renderer when hidden #1144
Conversation
|
Here's an annotated timeline of the change within VS Code doing the following:
To give an idea of the time saved, the draws on the busy terminal before the switch are about 5ms, 5ms and 2ms every available animation frame. |
|
Very nice and well written PR, I'm more happy to get this merged! |
|
|
|
LGTM |
|
Linux tests are passing, merging this in (mac agents are backed up) |
Tyriar
merged commit eac14a1
into
xtermjs:master
1 check was pending
1 check was pending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #880
@mofux seems to work nicely in Chrome, what do you think? This can save like 5ms a frame for heavy operations🔥