Use IntersectionObserver to turn off renderer when hidden#1144
Merged
Conversation
Member
Author
|
Here's an annotated timeline of the change within VS Code doing the following:
To give an idea of the time saved, the draws on the busy terminal before the switch are about 5ms, 5ms and 2ms every available animation frame. |
mofux
approved these changes
Dec 12, 2017
mofux
left a comment
mofux
left a comment
Contributor
There was a problem hiding this comment.
Very nice and well written PR, I'm more happy to get this merged!
Member
Author
|
🎉 will wait until v3 is done before merging it in. |
parisk
approved these changes
Dec 16, 2017
parisk
left a comment
parisk
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍. Can't wait to see this in 3.1.
Member
Author
|
Linux tests are passing, merging this in (mac agents are backed up) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #880
@mofux seems to work nicely in Chrome, what do you think? This can save like 5ms a frame for heavy operations 🔥