Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
Tyriar
self-assigned this
Dec 11, 2017
Tyriar
requested a review
from
mofux
Dec 11, 2017
This comment has been minimized.
This comment has been minimized.
|
Here's an annotated timeline of the change within VS Code doing the following:
To give an idea of the time saved, the draws on the busy terminal before the switch are about 5ms, 5ms and 2ms every available animation frame. |
Tyriar
added this to the 3.1.0 milestone
Dec 11, 2017
mofux
approved these changes
Dec 12, 2017
Very nice and well written PR, I'm more happy to get this merged!
This comment has been minimized.
This comment has been minimized.
|
|
Tyriar
changed the base branch from
v3
to
master
Jan 5, 2018
Tyriar
added some commits
Jan 5, 2018
This comment has been minimized.
This comment has been minimized.
|
Linux tests are passing, merging this in (mac agents are backed up) |
Tyriar
merged commit eac14a1
into
xtermjs:master
Jan 5, 2018
1 check was pending
continuous-integration/travis-ci/pr
The Travis CI build is in progress
Details
Tyriar
deleted the
Tyriar:880_renderer_pause
branch
Jan 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Tyriar commentedDec 11, 2017
Fixes #880
@mofux seems to work nicely in Chrome, what do you think? This can save like 5ms a frame for heavy operations🔥