-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getCoordsRelativeToElement: use getBoundingClientRect and clientX/Y. #1788
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @gou4shi1, this change causes the selection to behave badly when the cursor is outside of the viewport:
Also the tests fail.
@mofux would appreciate a review on this when you get a chance, it's scary changing old code like this 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm it's working for static, absolute and fixed positioned elements 👍The code is also a good improvement to what was in place before 😅
@Tyriar Please feel free to merge. |
Thanks for the PR @gou4shi1, it's much better than it was 👍 |
#1684