Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getCoordsRelativeToElement: use getBoundingClientRect and clientX/Y. #1788

Merged
merged 5 commits into from
Dec 10, 2018
Merged

getCoordsRelativeToElement: use getBoundingClientRect and clientX/Y. #1788

merged 5 commits into from
Dec 10, 2018

Conversation

gou4shi1
Copy link
Contributor

Tyriar
Tyriar requested changes Nov 23, 2018
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gou4shi1, this change causes the selection to behave badly when the cursor is outside of the viewport:

kapture 2018-11-23 at 8 25 42

Also the tests fail.

@Tyriar Tyriar added the work-in-progress Do not merge label Nov 23, 2018
@Tyriar Tyriar requested a review from mofux December 9, 2018 18:00
@Tyriar Tyriar added this to the 3.10.0 milestone Dec 9, 2018
@Tyriar
Copy link
Member

Tyriar commented Dec 9, 2018

@mofux would appreciate a review on this when you get a chance, it's scary changing old code like this 😄

mofux
mofux approved these changes Dec 9, 2018
View reviewed changes
Copy link
Contributor

@mofux mofux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm it's working for static, absolute and fixed positioned elements 👍The code is also a good improvement to what was in place before 😅

@mofux
Copy link
Contributor

mofux commented Dec 9, 2018

@Tyriar Please feel free to merge.

@Tyriar Tyriar removed the work-in-progress Do not merge label Dec 10, 2018
@Tyriar
Copy link
Member

Tyriar commented Dec 10, 2018

Thanks for the PR @gou4shi1, it's much better than it was 👍

@Tyriar Tyriar merged commit 65877d4 into xtermjs:master Dec 10, 2018
@gou4shi1
Copy link
Contributor Author

@Tyriar Thanks for your fix and merge!
@mofux Thanks for you review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

@mofux mofux mofux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gou4shi1 @Tyriar @mofux