Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove conditional preventing search in wrapped line #2520

Open
wants to merge 3 commits into
base: master
from

Conversation

@miggs125
Copy link
Contributor

miggs125 commented Oct 27, 2019

fixes #2325. I removed a conditional that appears to prevent searching in wrapped lines.

miggs125 added 3 commits Oct 27, 2019
@@ -228,11 +228,6 @@ export class SearchAddon implements ITerminalAddon {
protected _findInLine(term: string, row: number, col: number, searchOptions: ISearchOptions = {}, isReverseSearch: boolean = false): ISearchResult | undefined {
const terminal = this._terminal!;

// Ignore wrapped lines, only consider on unwrapped line (first row of command string).

This comment has been minimized.

Copy link
@Tyriar

Tyriar Oct 29, 2019

Member

Hmm, I'm not sure we can remove this. The idea with this early exit was to only allow searching from the first line since we need to find terms that could span multiple lines. The call to _translateBufferLineToStringWithWrap just below this is meant to fetch the entire string for the wrapped line that could include multiple individual terminal rows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.