Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding parserMRC #145

Merged
merged 4 commits into from Apr 2, 2014
Merged

Adding parserMRC #145

merged 4 commits into from Apr 2, 2014

Conversation

emilysperanza
Copy link
Contributor

Added ability to view .mrc and .st file formats:
http://bio3d.colorado.edu/imod/doc/mrc_format.txt
.mrc is the standard file format for viewing electron microscopy tomography data.

@NicolasRannou
Copy link
Member

Did you try to compile it?

It looks like there are some issues:

  • indentation in loader.js is incorrect
  • some indentation in parserMRC is incorrect
  • parseInt( number ) should be parseInt(number, 10) in parserMRC
  • filpEndianness typo - code not working. Should we just get rid of it for now?

Could you please re-submit a new patch?

Thanks

@emilysperanza
Copy link
Contributor Author

New Patch:
We have compiled the code and it has worked.
I fixed the indentation problems and removed the lines with the typo.

haehn added a commit that referenced this pull request Apr 2, 2014
@haehn haehn merged commit d5bab13 into xtk:master Apr 2, 2014
@haehn
Copy link
Member

haehn commented Apr 2, 2014

@emilysperanza Thanks!

angleto pushed a commit to angleto/X that referenced this pull request Aug 22, 2015
Fix parent class validity check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants