Skip to content

removing legacy field #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
reklis wants to merge 1 commit into from
Closed

removing legacy field #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 1 addition & 49 deletions Sources/DeveloperAPI/Generated/Types.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2664,65 +2664,17 @@ public enum Components {
}
/// - Remark: Generated from `#/components/schemas/BundleIdCapabilityCreateRequest/data/relationships/bundleId`.
public var bundleId: Components.Schemas.BundleIdCapabilityCreateRequest.DataPayload.RelationshipsPayload.BundleIdPayload
/// - Remark: Generated from `#/components/schemas/BundleIdCapabilityCreateRequest/data/relationships/capability`.
public struct CapabilityPayload: Codable, Hashable, Sendable {
/// - Remark: Generated from `#/components/schemas/BundleIdCapabilityCreateRequest/data/relationships/capability/data`.
public struct DataPayload: Codable, Hashable, Sendable {
/// - Remark: Generated from `#/components/schemas/BundleIdCapabilityCreateRequest/data/relationships/capability/data/type`.
@frozen public enum _TypePayload: String, Codable, Hashable, Sendable, CaseIterable {
case capabilities = "capabilities"
}
/// - Remark: Generated from `#/components/schemas/BundleIdCapabilityCreateRequest/data/relationships/capability/data/type`.
public var _type: Components.Schemas.BundleIdCapabilityCreateRequest.DataPayload.RelationshipsPayload.CapabilityPayload.DataPayload._TypePayload
/// - Remark: Generated from `#/components/schemas/BundleIdCapabilityCreateRequest/data/relationships/capability/data/id`.
public var id: Components.Schemas.CapabilityType
/// Creates a new `DataPayload`.
///
/// - Parameters:
/// - _type:
/// - id:
public init(
_type: Components.Schemas.BundleIdCapabilityCreateRequest.DataPayload.RelationshipsPayload.CapabilityPayload.DataPayload._TypePayload,
id: Components.Schemas.CapabilityType
) {
self._type = _type
self.id = id
}
public enum CodingKeys: String, CodingKey {
case _type = "type"
case id
}
}
/// - Remark: Generated from `#/components/schemas/BundleIdCapabilityCreateRequest/data/relationships/capability/data`.
public var data: Components.Schemas.BundleIdCapabilityCreateRequest.DataPayload.RelationshipsPayload.CapabilityPayload.DataPayload
/// Creates a new `CapabilityPayload`.
///
/// - Parameters:
/// - data:
public init(data: Components.Schemas.BundleIdCapabilityCreateRequest.DataPayload.RelationshipsPayload.CapabilityPayload.DataPayload) {
self.data = data
}
public enum CodingKeys: String, CodingKey {
case data
}
}
/// - Remark: Generated from `#/components/schemas/BundleIdCapabilityCreateRequest/data/relationships/capability`.
public var capability: Components.Schemas.BundleIdCapabilityCreateRequest.DataPayload.RelationshipsPayload.CapabilityPayload
/// Creates a new `RelationshipsPayload`.
///
/// - Parameters:
/// - bundleId:
/// - capability:
public init(
bundleId: Components.Schemas.BundleIdCapabilityCreateRequest.DataPayload.RelationshipsPayload.BundleIdPayload,
capability: Components.Schemas.BundleIdCapabilityCreateRequest.DataPayload.RelationshipsPayload.CapabilityPayload
bundleId: Components.Schemas.BundleIdCapabilityCreateRequest.DataPayload.RelationshipsPayload.BundleIdPayload
) {
self.bundleId = bundleId
self.capability = capability
}
public enum CodingKeys: String, CodingKey {
case bundleId
case capability
}
}
/// - Remark: Generated from `#/components/schemas/BundleIdCapabilityCreateRequest/data/relationships`.
Expand Down
32 changes: 7 additions & 25 deletions Sources/DeveloperAPI/patch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,31 +64,13 @@ function openAll(schema, path = []) {

function patch(schema) {
const schemas = schema.components.schemas;

// this field is required when using the private Xcode API
update(schemas.BundleIdCapabilityCreateRequest.properties.data.properties.relationships, {
properties: {
capability: {
type: 'object',
properties: {
data: {
type: 'object',
properties: {
type: {
type: 'string',
enum: ['capabilities'],
},
id: { $ref: '#/components/schemas/CapabilityType' },
},
required: ['id', 'type'],
},
},
required: ['data'],
}
},
required: ['capability'],
})


// The private Xcode/ds2 API used to require an extra `capability` relationship
// on BundleIdCapabilityCreateRequest. As of 2026 it now rejects that field with
// ENTITY_ERROR.RELATIONSHIP.UNKNOWN ("'capability' is not a relationship on
// the resource 'bundleIdCapabilities'"), so we no longer add it — the public
// ASC schema with only `bundleId` is now what ds2 expects.

// we don't use this but it triggers a deprecation warning. see:
// https://github.com/apple/swift-openapi-generator/issues/715
schemas.App.properties.relationships.properties.inAppPurchases.deprecated = false;
Expand Down
7 changes: 0 additions & 7 deletions Sources/XKit/DeveloperServices/App IDs/DeveloperServicesAddAppOperation.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,13 +136,6 @@ public struct DeveloperServicesAddAppOperation: DeveloperServicesOperation {
_type: .bundleIds,
id: appID.id
)
),
// not public but required when using ds2 API
capability: .init(
data: .init(
_type: .capabilities,
id: typ
)
)
)
)))
Expand Down