Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
[WIP] better Stack validation and new package #229
I've had some time to look into validation of ast's, more specifically into type checking. This is a prototype that type checks a subset of all instructions and opts out of anything that is not yet supported, so it should never throw errors because something is not yet supported.
The idea is to run every function instruction per instruction and check if the types work out. In addition to that there is a
There is a lot of work left to do, but the following testcases illustrate what type errors are already being caught correctly:
@ColinEberhardt I already discussed a bit over Slack with Sven (should probably have used the public channel, sorry!) but if you have any inputs/suggestions/concerns I am happy to take them
(The code contains some weird checks and corner cases due to inconsistencies in the AST format, I'll make issues about them).
No worries - looks good to me, just a couple of minor comments.