Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InstanceID error? #3

Closed
chengjianxi opened this issue Dec 21, 2021 · 6 comments
Closed

InstanceID error? #3

chengjianxi opened this issue Dec 21, 2021 · 6 comments

Comments

@chengjianxi
Copy link
Contributor 

InstanceID: fmt.Sprintf("%s:%s:%d", ip, config.App, config.Port),

or

InstanceID: fmt.Sprintf("%s:%s:%d", config.App, ip, config.Port),

which right?
@chengjianxi
Copy link
Contributor Author

可能两个都对，但是我们需要的InstanceID格式是第二种，这个建议把instance导出，支持自定义比较好

xuanbo added a commit that referenced this issue Dec 21, 2021
@xuanbo
InstanceID支持自定义 #3
2589e1f
@xuanbo
Copy link
Owner

xuanbo commented Dec 21, 2021

暂时先让 InstanceID 能够自定义

@xuanbo
Copy link
Owner

xuanbo commented Dec 21, 2021

目前 java client 是用的第一种，可以从 metadata 中自定义

@chengjianxi
Copy link
Contributor Author

@xuanbo 非常效率，感谢！！！

@chengjianxi
Copy link
Contributor Author

别忘了发布版本啊

@xuanbo
Copy link
Owner

xuanbo commented Dec 21, 2021

好了，可以使用v0.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chengjianxi @xuanbo