From 0d8ca8124de9b3a5f6398a28d79baca935a1f96c Mon Sep 17 00:00:00 2001 From: sanemat Date: Mon, 24 Dec 2012 17:09:54 +0900 Subject: [PATCH 1/8] Add rake default to description --- railties/Rakefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/railties/Rakefile b/railties/Rakefile index 8576275aea997..ab61d8eb112e8 100644 --- a/railties/Rakefile +++ b/railties/Rakefile @@ -4,7 +4,7 @@ require 'rubygems/package_task' require 'date' require 'rbconfig' - +desc "Default Task" task :default => :test task :test => 'test:isolated' From a3309caf338830849acd826bc6ad14f972e787db Mon Sep 17 00:00:00 2001 From: sanemat Date: Mon, 24 Dec 2012 17:10:18 +0900 Subject: [PATCH 2/8] Add rake test description --- railties/Rakefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/railties/Rakefile b/railties/Rakefile index ab61d8eb112e8..1b437947a44aa 100644 --- a/railties/Rakefile +++ b/railties/Rakefile @@ -6,6 +6,8 @@ require 'rbconfig' desc "Default Task" task :default => :test + +desc "Run all unit tests" task :test => 'test:isolated' namespace :test do From 41381c19d1f3920ee9540aff0d35209cb43fb057 Mon Sep 17 00:00:00 2001 From: Ace Suares Date: Mon, 24 Dec 2012 08:14:14 -0400 Subject: [PATCH 3/8] reminder to run bundle after setting up rails-dev-box --- guides/source/contributing_to_ruby_on_rails.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/guides/source/contributing_to_ruby_on_rails.md b/guides/source/contributing_to_ruby_on_rails.md index ce2a5a49026f4..59c200fe0c67c 100644 --- a/guides/source/contributing_to_ruby_on_rails.md +++ b/guides/source/contributing_to_ruby_on_rails.md @@ -49,6 +49,13 @@ To move on from submitting bugs to helping resolve existing issues or contributi The easiest and recommended way to get a development environment ready to hack is to use the [Rails development box](https://github.com/rails/rails-dev-box). +After you have setup your Rails development box and cloned your Rails fork on the host computer, don't forget to run Bundler before you start testing. + + host $ vagrant ssh + Welcome to Ubuntu 12.04 LTS... + ... + vagrant@rails-dev-box:~$ cd /vagrant/rails && bundle install + ### The Hard Way In case you can't use the Rails development box, see section above, check [this other guide](development_dependencies_install.html). From 52691c369c559d726d94d8551b5b809621e31a84 Mon Sep 17 00:00:00 2001 From: Colin Kelley Date: Wed, 26 Dec 2012 17:02:54 -0800 Subject: [PATCH 4/8] removed TIP: :allow_nil/:allow_blank is ignored by the presence validator These tips were documenting an inconsistency issue https://github.com/rails/rails/issues/8621. That issue is resolved by https://github.com/rails/rails/issues/8622. --- guides/source/active_record_validations.md | 4 ---- 1 file changed, 4 deletions(-) diff --git a/guides/source/active_record_validations.md b/guides/source/active_record_validations.md index 822d12aa3a437..5797c93ae7e49 100644 --- a/guides/source/active_record_validations.md +++ b/guides/source/active_record_validations.md @@ -656,8 +656,6 @@ class Coffee < ActiveRecord::Base end ``` -TIP: `:allow_nil` is ignored by the presence validator. - ### `:allow_blank` The `:allow_blank` option is similar to the `:allow_nil` option. This option @@ -673,8 +671,6 @@ Topic.create("title" => "").valid? # => true Topic.create("title" => nil).valid? # => true ``` -TIP: `:allow_blank` is ignored by the presence validator. - ### `:message` As you've already seen, the `:message` option lets you specify the message that From e63b752f635f62e22859e034a55d7918945c3961 Mon Sep 17 00:00:00 2001 From: Fabrizio Regini Date: Thu, 27 Dec 2012 18:11:21 +0100 Subject: [PATCH 5/8] Fixed couple of typos --- guides/source/active_support_instrumentation.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guides/source/active_support_instrumentation.md b/guides/source/active_support_instrumentation.md index cf5a51fc5b233..6b3be6994270e 100644 --- a/guides/source/active_support_instrumentation.md +++ b/guides/source/active_support_instrumentation.md @@ -432,7 +432,7 @@ from block args like this: ```ruby ActiveSupport::Notifications.subscribe "process_action.action_controller" do |*args| - event = ActiveSupport::Notification::Event.new args + event = ActiveSupport::Notifications::Event.new *args event.name # => "process_action.action_controller" event.duration # => 10 (in milliseconds) From 8dd2c71d2671ddc87bfdf18ebb35a4ca382e59f6 Mon Sep 17 00:00:00 2001 From: Vijay Dev Date: Sat, 29 Dec 2012 00:07:02 +0530 Subject: [PATCH 6/8] Revert "reminder to run bundle after setting up rails-dev-box" This reverts commit 41381c19d1f3920ee9540aff0d35209cb43fb057. Reason: This doesn't quite fit the flow where it's added. Let's add this someplace else if it's explicitly required. [ci skip] --- guides/source/contributing_to_ruby_on_rails.md | 7 ------- 1 file changed, 7 deletions(-) diff --git a/guides/source/contributing_to_ruby_on_rails.md b/guides/source/contributing_to_ruby_on_rails.md index 59c200fe0c67c..ce2a5a49026f4 100644 --- a/guides/source/contributing_to_ruby_on_rails.md +++ b/guides/source/contributing_to_ruby_on_rails.md @@ -49,13 +49,6 @@ To move on from submitting bugs to helping resolve existing issues or contributi The easiest and recommended way to get a development environment ready to hack is to use the [Rails development box](https://github.com/rails/rails-dev-box). -After you have setup your Rails development box and cloned your Rails fork on the host computer, don't forget to run Bundler before you start testing. - - host $ vagrant ssh - Welcome to Ubuntu 12.04 LTS... - ... - vagrant@rails-dev-box:~$ cd /vagrant/rails && bundle install - ### The Hard Way In case you can't use the Rails development box, see section above, check [this other guide](development_dependencies_install.html). From 09a347f0cd6929733281049b6ae21aa23d587fb0 Mon Sep 17 00:00:00 2001 From: Vijay Dev Date: Sat, 29 Dec 2012 00:08:37 +0530 Subject: [PATCH 7/8] Revert "Add rake default to description" This reverts commit 0d8ca8124de9b3a5f6398a28d79baca935a1f96c. Reason: docrails isn't the place to do this. Also, I feel this is not really required. [ci skip] --- railties/Rakefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/railties/Rakefile b/railties/Rakefile index 1b437947a44aa..eb068fc526a44 100644 --- a/railties/Rakefile +++ b/railties/Rakefile @@ -4,7 +4,7 @@ require 'rubygems/package_task' require 'date' require 'rbconfig' -desc "Default Task" + task :default => :test desc "Run all unit tests" From 896a04971be6ec0df7df70545ee85e7978d3e41a Mon Sep 17 00:00:00 2001 From: Vijay Dev Date: Sat, 29 Dec 2012 00:15:22 +0530 Subject: [PATCH 8/8] Revert "Add rake test description" This reverts commit a3309caf338830849acd826bc6ad14f972e787db. Reason: docrails isn't the place to do this. [ci skip] --- railties/Rakefile | 2 -- 1 file changed, 2 deletions(-) diff --git a/railties/Rakefile b/railties/Rakefile index eb068fc526a44..8576275aea997 100644 --- a/railties/Rakefile +++ b/railties/Rakefile @@ -6,8 +6,6 @@ require 'rbconfig' task :default => :test - -desc "Run all unit tests" task :test => 'test:isolated' namespace :test do