From cbf32f736b9244722d0f6d24588f8d81631f96ee Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juanjo=20Baz=C3=A1n?= Date: Fri, 11 Aug 2023 13:47:42 +0200 Subject: [PATCH] Page is a number --- lib/theoj/retraction_notice.rb | 2 +- spec/lib/retraction_notice_spec.rb | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/theoj/retraction_notice.rb b/lib/theoj/retraction_notice.rb index 9cfc9a5..3c5f4c1 100644 --- a/lib/theoj/retraction_notice.rb +++ b/lib/theoj/retraction_notice.rb @@ -30,7 +30,7 @@ def metadata volume: journal.current_volume, issue: journal.current_issue, year: journal.current_year, - page: "#{retracted_paper.page}R", + page: retracted_paper.page, journal_alias: journal.alias, software_review_url: retracted_paper.paper_review, archive_doi: retracted_paper.software_archive.to_s.gsub("https://doi.org/", ""), diff --git a/spec/lib/retraction_notice_spec.rb b/spec/lib/retraction_notice_spec.rb index 36bf044..2717a45 100644 --- a/spec/lib/retraction_notice_spec.rb +++ b/spec/lib/retraction_notice_spec.rb @@ -80,7 +80,7 @@ volume: @journal.current_volume, issue: @journal.current_issue, year: @journal.current_year, - page: "45678R", + page: "45678", journal_alias: "test_journal", software_review_url: "https://github.com/openjournals/test_journal/issues/5567", archive_doi: "10.AAAA/zenodo.33", @@ -114,11 +114,11 @@ volume: @journal.current_volume, issue: @journal.current_issue, year: @journal.current_year, - page: "45678R" + page: "45678" } }.to_json ), - citation_string: "Editorial Board, (#{@journal.current_year}). Retraction notice for: Test paper. Test Journal, #{@journal.current_volume}(#{@journal.current_issue}), 45678R, https://doi.org/paper-doiR" + citation_string: "Editorial Board, (#{@journal.current_year}). Retraction notice for: Test paper. Test Journal, #{@journal.current_volume}(#{@journal.current_issue}), 45678, https://doi.org/paper-doiR" } expect(@retraction_notice.deposit_payload).to eq(expected_deposit_payload) @@ -126,7 +126,7 @@ end it "should create a valid citation string" do - expect(@retraction_notice.citation_string).to eq "Editorial Board, (#{@journal.current_year}). Retraction notice for: Test paper. Test Journal, #{@journal.current_volume}(#{@journal.current_issue}), 45678R, https://doi.org/paper-doiR" + expect(@retraction_notice.citation_string).to eq "Editorial Board, (#{@journal.current_year}). Retraction notice for: Test paper. Test Journal, #{@journal.current_volume}(#{@journal.current_issue}), 45678, https://doi.org/paper-doiR" end describe "#deposit!" do