Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Settings(settings)' accepts too few arguments to be used as a decorator here. #7

Closed
jwulf opened this issue Nov 24, 2018 · 3 comments · Fixed by #8
Closed

'Settings(settings)' accepts too few arguments to be used as a decorator here. #7

jwulf opened this issue Nov 24, 2018 · 3 comments · Fixed by #8

Comments

@jwulf
Copy link
Contributor

jwulf commented Nov 24, 2018 •
edited 

 'Settings(settings)' accepts too few arguments to be used as a decorator here. Did youmean to call it first and write '@Settings(settings)()'?

screen shot 2018-11-24 at 2 58 53 pm

With version 1.1.0 of the package. I get this error when compiling.
This was referenced Nov 24, 2018
Closed
Merged
@jwulf
Copy link
Contributor Author

jwulf commented Nov 26, 2018

Fixed with #8

@xuezier
Copy link
Owner

xuezier commented Nov 26, 2018 •
edited

@jwulf

Okay, I found the mistake.
It's because the Setting function returns a decorator that does not require parameters.
I have improved it.

It's not a bug, but it's a nonstandard of decorator defining.

@xuezier
Copy link
Owner

xuezier commented Nov 26, 2018

Fixed with #8

OK ， I just saw this mr.
thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Compile fix jwulf/grpc-server-ts
2 participants
@jwulf @xuezier