Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Console runner return codes" was deleted from the .NET Core docs #1810

Closed
christianspecht opened this issue Sep 7, 2018 · 4 comments
Closed

Comments

@christianspecht
Copy link

On the "Getting started with xUnit.net (.NET Core / ASP.NET Core)" page, there's a bunch of navigation links at the top.

The last one is Console runner return codes, but the actual content is missing from the page. It was deleted in this commit by @bradwilson.

Was the deletion by mistake or will the return codes be changed?

@bradwilson
Copy link
Member

They were deleted, because they were only valid for dotnet xunit, which is no longer supported.

@bradwilson
Copy link
Member

I've just removed the broken link.

@christianspecht
Copy link
Author

@bradwilson: Okay, but is there any kind of replacement for the return codes?

Previously, I had a PowerShell build script which quit the whole build if at least one test failed (return code 1):

dotnet test "$PSScriptRoot\src\Foo.Tests\Foo.Tests.csproj" -c Release
if ($LASTEXITCODE -eq 1) {
    exit
}

How can I do this without the return codes?

@bradwilson
Copy link
Member

We don't control the return code, VSTest does. That would be a question for that team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants