Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix builtin shadowing #132

Merged
merged 2 commits into from Jun 25, 2019
Merged

fix: fix builtin shadowing #132

merged 2 commits into from Jun 25, 2019

Conversation

@HAOYUatHZ
Copy link
Contributor

HAOYUatHZ commented Jun 24, 2019

as error, len & cap are predeclared identifier in GoLang, we'd better avoid using them as var name to avoid shadowing, which might introduce bugs if careless

@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Jun 24, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

MichelleZ left a comment

LGTM

@yucaowang yucaowang requested review from duanbing and icexin Jun 25, 2019
@yucaowang yucaowang merged commit ccf43da into xuperchain:master Jun 25, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
MichelleZ pushed a commit to MichelleZ/xuperunion that referenced this pull request Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.