XWIKI-9340: Integrate Workspaces in the default XE XAR (first commit). #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xwiki-enterprise-ui/pom.xml
Outdated
There was a problem hiding this comment.
This is not required by workspace-ui and maybe we should not include it in the default XE-ui. Admins looking for a farm setup can install wiki-manager-ui with EM when they need it.
There was a problem hiding this comment.
The plan is to not release XEM anymore but only XE. So in order to not lose out-of-the-box features, I have added wiki-manager-ui to XE too.
There was a problem hiding this comment.
Make sure you specify that on the mailing list, because, in your mail, you`ve only mentioned Workspaces. IMO, the WikiManager app is bloating the default XE xar; please make sure we want it there.
There was a problem hiding this comment.
You are right. I am going to ask :)
* add maven-duplicate-finder-plugin <ignoredResources> entries
…i-enterprise-workspace-ui and xwiki-enterprise-workspace-ui-all).
Conflicts: xwiki-enterprise-web/pom.xml
…e we gonna drop xwiki-manager). This may be reverted, depending on http://xwiki.markmail.org/thread/bxjxnpahqd7cameh results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step: add new dependencies to XE.
I know all is not done is this commit. For example: I did not fix how to generate the workspace-template.xar. I'm waiting for feedbacks on my emails for that.
This commit is just a first step, in order to make things progressively.