Skip to content

Conversation

mouhb
Copy link
Contributor

@mouhb mouhb commented Jul 30, 2015

In this PR I added the possibility to play a video attachment using Video.js library (http://www.videojs.com/)

Added macro parameters :

  • attachment : This parameter is a boolean that indicates if the video is an URL or an attachment. The default value is false.
  • attachmentName : The name of the video attachment
  • videoPoster : The poster of the video is an image attachment that will be displayed before starting playing the video.

For the moment the videos formats supported are : mp4, webm and ogv

@cjdelisle cjdelisle merged commit cca2aab into xwiki-contrib:master Aug 25, 2015
@vmassol
Copy link
Member

vmassol commented Aug 28, 2015

Has this been documented at http://extensions.xwiki.org/xwiki/bin/view/Extension/Video+Macro ? doesnt seem so.

@Enygma2002
Copy link
Member

Really nice feature that we were really missing!

Either the developer ( @mouhb ) or the 1.6 release manager ( @cjdelisle ) should add a few lines of documentation on the extension page or users will never know about it!

@mouhb
Copy link
Contributor Author

mouhb commented Sep 2, 2015

Thanks for your comments. I will check all ASAP.

@mflorea
Copy link
Member

mflorea commented Sep 2, 2015

Really nice feature that we were really missing!

@Enygma2002 JW Player Macro does this since a long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants