Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Aggresive shutdown doesn't work with PureJavaProcessManager #5

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants

No description provided.

Owner

brunojcm commented on 3d67ed8 Aug 16, 2012

This commit make sure that the process will be killed, even if we have a PureJavaProcessManager. PureJavaProcessManager is not able to find pid's, but we have a reference to the process and it can be killed anyway.

I see, with the if guard, PureJavaProcessManager can't kill the process, but without it the other two process managers are going to throw an exception...

Ah, the solution is simple, just add another try..catch block. Could you update the pull request, please?

@sdumitriu sdumitriu was assigned Aug 16, 2012

Any particular reason for this change?

Owner

sdumitriu commented Aug 18, 2012

Fixed in 1d1615a

@sdumitriu sdumitriu closed this Aug 18, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment