Permalink
Browse files

[Misc] Remove checkstyle config hacks that are no longer needed

  • Loading branch information...
1 parent 08ae34f commit bff9cfd7cf846d79a6f72c33c7a1cfb0214e5b33 @vmassol vmassol committed Mar 23, 2012
@@ -238,10 +238,7 @@
<module name="ModifierOrder"/>
<module name="MultipleStringLiterals">
- <property name="ignoreStringsRegexp" value='^("")|("[0-9]")|(" ")|("\]")|("\] = \[")|("unchecked")$'/>
- <!-- Newer versions of the checkstyle plugin (not the one used by the maven plugin) allow to ignore annotations.
- <property name="ignoreOccurrenceContext" value="ANNOTATION"/>
- -->
+ <property name="ignoreStringsRegexp" value='^("")|("[0-9]")|(" ")|("\]")$'/>
@sdumitriu
sdumitriu Mar 23, 2012 Member

Why did you remove "unchecked"? Is the current checkstyle version smarter so that it ignores annotations?

@vmassol
vmassol Mar 24, 2012 Member

I removed it because it's unnecessary. As you can see in the comment I removed:

<!--  Newer versions of the checkstyle plugin (not the one used by the maven plugin) allow to ignore annotations.
<property name="ignoreOccurrenceContext" value="ANNOTATION"/>

I also ran the build build again to verify I didn't break anything first of course.

</module>
<module name="MultipleVariableDeclarations"/>

0 comments on commit bff9cfd

Please sign in to comment.