Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

[Misc] Remove checkstyle config hacks that are no longer needed

  • Loading branch information...
commit bff9cfd7cf846d79a6f72c33c7a1cfb0214e5b33 1 parent 08ae34f
Vincent Massol vmassol authored
5 xwiki-commons-tools/xwiki-commons-tool-validation-resources/src/main/resources/checkstyle.xml
@@ -238,10 +238,7 @@
238 238 <module name="ModifierOrder"/>
239 239
240 240 <module name="MultipleStringLiterals">
241   - <property name="ignoreStringsRegexp" value='^("")|("[0-9]")|(" ")|("\]")|("\] = \[")|("unchecked")$'/>
242   - <!-- Newer versions of the checkstyle plugin (not the one used by the maven plugin) allow to ignore annotations.
243   - <property name="ignoreOccurrenceContext" value="ANNOTATION"/>
244   - -->
  241 + <property name="ignoreStringsRegexp" value='^("")|("[0-9]")|(" ")|("\]")$'/>
245 242 </module>
246 243
247 244 <module name="MultipleVariableDeclarations"/>

0 comments on commit bff9cfd

Sergiu Dumitriu

Why did you remove "unchecked"? Is the current checkstyle version smarter so that it ignores annotations?

Vincent Massol

I removed it because it's unnecessary. As you can see in the comment I removed:

<!--  Newer versions of the checkstyle plugin (not the one used by the maven plugin) allow to ignore annotations.
<property name="ignoreOccurrenceContext" value="ANNOTATION"/>

I also ran the build build again to verify I didn't break anything first of course.

Please sign in to comment.
Something went wrong with that request. Please try again.