Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: xwiki/xwiki-platform
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ca119eaf3f8f
Choose a base ref
...
head repository: xwiki/xwiki-platform
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f1a4fba41dd1
Choose a head ref
  • 4 commits
  • 5 files changed
  • 2 contributors

Commits on Aug 29, 2025

  1. XWIKI-22806: Refactor dataeditors.js to get rid of prototypejs (#3528) 

     * Introduction of action in meta.js
 * Refactoring of dataeditors.js to get rid of prototype and to use
xm.action for performing AJAX requests.
* Apply suggestions from code review

Apply changes following @mflorea's review
  * Use standard l10n loader
  * Get rid of prototypejs Class.create
  * Use CSS.escape static call
  * Fix syntax error
  * use jquery-sortable for handling sorting the properties
  * Fix indentation
  * Fix initialization
  * Fix remaining bugs
  * Fix test

---------

Co-authored-by: Marius Dumitru Florea <marius@xwiki.com>
(cherry picked from commit b0dbff0)
    @surli @mflorea
    surli and mflorea committed Aug 29, 2025
    Configuration menu
    Copy the full SHA
    848929c View commit details
    Browse the repository at this point in the history

  2. XWIKI-22806: Refactor dataeditors.js to get rid of prototypejs 

      * Fix displaying the dialog to prevent user leaving the editor without
    saving

(cherry picked from commit 5702af8)
    @surli
    surli committed Aug 29, 2025
    Configuration menu
    Copy the full SHA
    1ec52ea View commit details
    Browse the repository at this point in the history

  3. XWIKI-22806: Refactor dataeditors.js to get rid of prototypejs 

      * Fix regression with class editor
  * Add integration test

(cherry picked from commit 3cc99b1)
    @surli
    surli committed Aug 29, 2025
    Configuration menu
    Copy the full SHA
    9e16040 View commit details
    Browse the repository at this point in the history

  4. XWIKI-22806: Refactor dataeditors.js to get rid of prototypejs 

      * Specify the path for jquery-ui dependency

(cherry picked from commit 95dcd39)
    @surli
    surli committed Aug 29, 2025
    Configuration menu
    Copy the full SHA
    f1a4fba View commit details
    Browse the repository at this point in the history
Loading