XWIKI-8286: Upgrade to Hibernate 5.1.8 #1012
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atallahade
commented
Jan 2, 2019
| // save object using the custom mapping | ||
| Map<String, Object> objmap = object.getCustomMappingMap(); | ||
| handledProps = bclass.getCustomMappingPropertyList(context); | ||
| Session dynamicSession = session.getSession(EntityMode.MAP); |
There was a problem hiding this comment.
This is not valid anymore and I'm not sure what will be the consequence of the removal.
There was a problem hiding this comment.
atallahade
commented
Jan 2, 2019
| Configuration config = getConfiguration(); | ||
| SessionFactoryImpl sfactory = (SessionFactoryImpl) config.buildSessionFactory(); | ||
| Settings settings = sfactory.getSettings(); | ||
| ConnectionProvider provider = ((SessionFactoryImpl) getSessionFactory()).getSettings().getConnectionProvider(); |
There was a problem hiding this comment.
The connectionProvider is not part of the settings anymore so setting it doesn't seem to be needed.
* Upgrade to Hibernate 4.0.1.Final. * Use the new hibernate package names. * Replace the 'session.connection()' with either the 'session.doWork()' method or by directly creating an sql query. * Adapt the DBCPConnectionProvider using C3P0ConnectionProvider as a model.
atallahade
force-pushed
the
feat-hibernate
branch
from
2174eca to
68b8fc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://jira.xwiki.org/browse/XWIKI-8286
Changes
Notes
Not everything could have been properly tested, especially migration classes.
The migration was made using: