XWIKI-6770: Add 'follow' action in the XWiki.XWikiGroupSheet livetable #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of actually containing it's code
- Pasted rightsUI.vm and minimised the use of the {{html}} macro by using it only in the section that produces html. First velocity section has been set to output='false'.
…te instead of actually containing it's code" This reverts commit e424dd2.
Note: Requires that XWIKI-6767 be fixed before it can work correctly since it is relying on the livetable actionCallback mechanism for ajaxActions.
- Applied Sergiu's suggestions for cleaning up the previous proposed patch.
|
Pull request updated. |
|
@Enygma2002 is this PR still needed? |
|
Thanks for the reminder, @atallahade. Watchlist is now deprecated and the approach was not ideal either. It would maybe make sense for the UserDirectory, but less for the XWikiGroupSheet. Closing it. |
manuelleduc
pushed a commit
that referenced
this pull request
Jul 8, 2022
…-integration Update from Weblate.
tmortagne
pushed a commit
that referenced
this pull request
Oct 4, 2023
TOUR-60: Cannot save the "Target Action" and "Query String" from the UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Requires that XWIKI-6767 be fixed before it can work correctly since it is relying on the livetable actionCallback mechanism for ajaxActions.
Additionally, I`ve left the CSS for the follow/unfollow actions in the XWikiGroupSheet and not moved it into livetable.css because they are not globally applicable like delete/edit/copy/etc. actions are.