XWIKI-13274 : Add NS support for Ratings space configuration #472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Retrieves the XWiki private API object. | ||
| * | ||
| * @return The XWiki private API object | ||
| */ |
|
This code is missing a unit test |
| * @param documentRef the document being rated or for which the existing ratings are fetched | ||
| * @return the lowest level ratings configuration doc | ||
| * @since 8.1M1 | ||
| */ |
There was a problem hiding this comment.
You should also add an @unstable annotation
|
I also see some code manipulating the configuration here Ideally we should only have one place i the Java API to get the config and the Script Service should call that API. |
* intoduced getConfigurationDocument() * refactored the getConfigurationParameter() + related code
|
PR replaced by 528. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.