XWIKI-7550 Allow multiple workspace templates for the user to choose from #70
Conversation
There was a problem hiding this comment.
That's not something we like to see...
There was a problem hiding this comment.
I've added this line because I've changed the public API of WorkspaceManager, but when I wrote **/WorkspaceManager.java, it still didn't compile.
I'd like to have a little help on this point.
There was a problem hiding this comment.
Fixed: it was **/WorkspaceManager, without the ".java" extension.
|
What is missing now is the UI for creating new workspace templates. In the currently proposed version, an admin needs to manually create (using the WikiManager application) the workspace templates that he wants to make available to the users. |
… from: * Fixed issues described on #70 . * Fixed: HTML code was not valid from the w3c validator point of view. * Fixed: A wrong merge on the UI.
… from: * Fixed issues described on #70 . * Fixed: HTML code was not valid from the w3c validator point of view. * Fixed: A wrong merge on the UI.
* Fixing a mistake.
* Fixing a mistake.
|
Maybe, in order to avoid mixing subwiki and workspace templates, we should create a 'template' field on the WorkspaceClass and make a UI for setting which workspace is a template. |
|
Please see my comment above for, what I believe to be, a better approach: #70 (comment) Basically, the idea was the other way around, using what already exists. You are suggesting to mark workspaces as templates (adding a new field to the workspace class), while I suggested to mark templates as workspaces instead. |
|
Ok. Just one thing: "workspacetemplate" does not have an WorkspaceManager.WorkspaceClass object. Question: should I add it manually to the list of templates or should I put the WorkspaceManager.WorkspaceClass object on workspacetemplate too? |
|
Well, the WorkspaceManager.Install page should automatically take care of this as an extra step. It should add the WorkspaceManager.WorkspaceClass at install time. On the long run, I think we should remove the hardcoded "workspacetemplate" name and replace it with a java method call in the workspaces script service. |
|
But if we add a WorkspaceManager.WorkspaceClass object for the template, then the template will be listed when you go to "browse workspaces". Do we want the template to be listed there? We may have to change the browse workspace too, in order to hide the templates. WDYT ? |
|
Of course, we need to update the browse workspace query in order to ignore workspace templates. |
XWIKI-7550 Allow multiple workspace templates for the user to choose from
… from: * Fixed issues described on xwiki/xwiki-platform#70 . * Fixed: HTML code was not valid from the w3c validator point of view. * Fixed: A wrong merge on the UI.
… from: * Fixed issues described on xwiki/xwiki-platform#70 . * Fixed: HTML code was not valid from the w3c validator point of view. * Fixed: A wrong merge on the UI.
3 participants
Hi. This is my first pull request. Hope it's fine.
Guillaume "Louis-Marie" Delhumeau.