XWIKI-15761: Improve look and feel of default pdf export #900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lucaa
commented
Oct 20, 2018
lucaa
commented
- Changed default font to sans fonts
- Added thin lines between doc header, doc footer and page content text
- Fixed the document pdfheader to display document titles instead of document space name
- Polished the document cover to display title and document metadata to the left and repeat the thin separator lines to preserve the same look and feel as the pages
* Changed default font to sans fonts * Added thin lines between doc header, doc footer and page content text * Fixed the document pdfheader to display document titles instead of document space name * Polished the document cover to display title and document metadata to the left and repeat the thin separator lines to preserve the same look and feel as the pages
atallahade
approved these changes
Oct 21, 2018
xwiki-platform-core/xwiki-platform-web/src/main/webapp/templates/pdfheader.vm
Outdated
Show resolved
Hide resolved
* Simplified condition for the type of parent in the pdfheader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.