Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty mapping objects are added when a previous mapping is cleared #24

Closed
oanat opened this issue Jan 30, 2020 · 2 comments
Closed

Empty mapping objects are added when a previous mapping is cleared #24

oanat opened this issue Jan 30, 2020 · 2 comments
Assignees
Milestone

Comments

@oanat
Copy link

@oanat oanat commented Jan 30, 2020

Steps to reproduce:

  • create a group or user mapping, e.g.

Mapping

  • delete the values for "last_name" and "cn:
  • click on "Save"

Result:

  • the mapping section displays 3 empty objects instead of 2

ClearMappingValues

  • when doing multiple updates on the same mapping the user can end up with many empty objects

Expected result: no extra empty objects should be added in this case.

@ilieandriuta
Copy link

@ilieandriuta ilieandriuta commented Mar 9, 2020

I've reproduced this issue on when just fill a mapping and just saving it afterwards (tested on Active Directory 1.7, Group Mapping).

@acotiuga
Copy link
Contributor

@acotiuga acotiuga commented Mar 24, 2020

Fixed in 581778f for #26.

@acotiuga acotiuga self-assigned this Mar 24, 2020
@acotiuga acotiuga added this to the 1.8 milestone Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants