Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The entries in group mapping can get merged #44

Closed
CamiAndrei opened this issue Apr 29, 2021 · 0 comments
Closed

The entries in group mapping can get merged #44

CamiAndrei opened this issue Apr 29, 2021 · 0 comments
Assignees
Milestone

Comments

@CamiAndrei
Copy link
Contributor

Steps to reproduce:

  • Active Directory groups mapping
  • Add some entries with identical XWiki groups or Active Directory groups
  • Save the configuration

Screenshot from 2021-04-29 13-58-56

Results:
Go back to the configuration:
Some entries were saved as merged of other entries.

Screenshot from 2021-04-29 13-58-22

Screenshot from 2021-04-29 14-14-44

e.g.: When the a XWiki Group is added multiple times, the value in Active Directory Group is added the same input multiple times. And the other way around, when the values in Active Directory Groups added are the same, in the XWiki Group the values are merge in the same field.

@CamiAndrei CamiAndrei assigned CamiAndrei and unassigned CamiAndrei Apr 29, 2021
@CamiAndrei CamiAndrei changed the title The entries in group maping can get merged The entries in group mapping can get merged Apr 29, 2021
@acotiuga acotiuga self-assigned this Apr 29, 2021
acotiuga added a commit that referenced this issue May 4, 2021
* the fields and groups mapping should accept duplicate "keys", as they are not real maps but "|" separated strings
* use the separator in each phase of key-value pair building : |A=| and |A=B|
* clean the extra separators used as support in the map building
@acotiuga acotiuga closed this as completed May 4, 2021
@acotiuga acotiuga added this to the 1.11 milestone May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants