Skip to content

Can't remove the first entry in Active Directory groups mapping #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
CamiAndrei opened this issue Apr 29, 2021 · 0 comments
Closed

Can't remove the first entry in Active Directory groups mapping #45

CamiAndrei opened this issue Apr 29, 2021 · 0 comments
Assignees
@acotiuga
Labels
Priority: Minor Type: Bug
Milestone
1.11

Comments

@CamiAndrei
Copy link
Contributor

CamiAndrei commented Apr 29, 2021 •
edited
Loading

Steps to reproduce:

  • Add some groups mapping
  • Save ( some other configuration is needed to save the configuration)
  • Clean all the mapping by removing the entries
  • Save the configuration
  • Go back to the mapping
    Results:
    The first entry is still there.

The reason for this issue is that when the mapping is empty, it needs to be an empty entry. And the empty entry isn't added when the mapping is removed.

A workaround for this issue is to remove the content for the first entry and not remove the entry itself.
@CamiAndrei CamiAndrei changed the title Can't remove the last entry in Active Directory groups mapping Can't remove the last first in Active Directory groups mapping Apr 29, 2021
@CamiAndrei CamiAndrei changed the title Can't remove the last first in Active Directory groups mapping Can't remove the first entry in Active Directory groups mapping Apr 29, 2021
@acotiuga acotiuga self-assigned this May 4, 2021
acotiuga added a commit that referenced this issue May 4, 2021
@acotiuga
Can't remove the first entry in Active Directory groups mapping #45
0bd7d93 
* all the remaining separators should be cleaned before save to avoid generating array of size 1 on split
* replaced hardcoded separators
@acotiuga acotiuga added this to the 1.11 milestone May 4, 2021
@acotiuga acotiuga closed this as completed May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acotiuga acotiuga

Labels
Priority: Minor Type: Bug
Projects
None yet
Milestone
1.11
Development

No branches or pull requests
2 participants
@acotiuga @CamiAndrei