Can't remove the first entry in Active Directory groups mapping #45

CamiAndrei · 2021-04-29T11:19:42Z

Steps to reproduce:

Add some groups mapping
Save ( some other configuration is needed to save the configuration)
Clean all the mapping by removing the entries
Save the configuration
Go back to the mapping
Results:
The first entry is still there.

The reason for this issue is that when the mapping is empty, it needs to be an empty entry. And the empty entry isn't added when the mapping is removed.

A workaround for this issue is to remove the content for the first entry and not remove the entry itself.

* all the remaining separators should be cleaned before save to avoid generating array of size 1 on split * replaced hardcoded separators

CamiAndrei added Priority: Minor Type: Bug labels Apr 29, 2021

CamiAndrei changed the title ~~Can't remove the last entry in Active Directory groups mapping~~ Can't remove the last first in Active Directory groups mapping Apr 29, 2021

CamiAndrei changed the title ~~Can't remove the last first in Active Directory groups mapping~~ Can't remove the first entry in Active Directory groups mapping Apr 29, 2021

acotiuga self-assigned this May 4, 2021

acotiuga added a commit that referenced this issue May 4, 2021

Can't remove the first entry in Active Directory groups mapping #45

0bd7d93

* all the remaining separators should be cleaned before save to avoid generating array of size 1 on split * replaced hardcoded separators

acotiuga added this to the 1.11 milestone May 4, 2021

acotiuga closed this as completed May 4, 2021

Can't remove the first entry in Active Directory groups mapping #45

Can't remove the first entry in Active Directory groups mapping #45

Comments

CamiAndrei commented Apr 29, 2021 • edited

CamiAndrei commented Apr 29, 2021 •

edited