Skip to content

/ application-diagram

forked from xwiki-contrib/application-diagram
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal links added to a text are not present on the generated svg #111

Closed
oanalavinia opened this issue Jan 31, 2020 · 0 comments
Closed

Internal links added to a text are not present on the generated svg #111

oanalavinia opened this issue Jan 31, 2020 · 0 comments
Assignees
@oanalavinia
Labels
Priority: Critical Type: Bug
Milestone
1.12.3

Comments

@oanalavinia
Copy link

@oanalavinia oanalavinia commented Jan 31, 2020 •
edited

Steps to reproduce:

  1. Create a new Diagram
  2. Add some text shapes
  3. Select a piece of text
  4. Click on the 'Link...' button below Insert from the right panel
  5. Select a wiki page > Apply
  6. Click Save & View
  7. Go to Attachments tab and select diagram.svg
  8. Try the inserted links

Expected result: Links work.
Actual results: Links don't work

The same issue can be reproduced on the svg export from the diagram menu
@oanalavinia oanalavinia changed the title Links added to a text are not present on the generated svg Internal links added to a text are not present on the generated svg Feb 3, 2020
oanalavinia added a commit to oanalavinia/application-diagram that referenced this issue Feb 3, 2020
@oanalavinia
Internal links added to a text are not present on the generated svg x…
28fbc4d 
…wikisas#111
@mflorea mflorea added this to the 1.13 milestone Feb 4, 2020
oanalavinia added a commit to oanalavinia/application-diagram that referenced this issue Feb 4, 2020
@oanalavinia
Internal links added to a text are not present on the generated svg x…
aa9dfa9 
…wikisas#111

* update all, not just the top level link nodes
* better name for svgHandler
oanalavinia added a commit to oanalavinia/application-diagram that referenced this issue Feb 5, 2020
@oanalavinia
Internal links added to a text are not present on the generated svg x…
73afba9 
…wikisas#111
oanalavinia added a commit that referenced this issue Feb 6, 2020
@oanalavinia
Internal links added to a text are not present on the generated svg #111
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8eb9c74 
 (#112)
@oanalavinia oanalavinia closed this Feb 6, 2020
@oanalavinia oanalavinia modified the milestones: 1.13, 1.12.3 Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oanalavinia oanalavinia

Labels
Priority: Critical Type: Bug
Projects
None yet
Milestone
  1.12.3
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@oanalavinia @mflorea
You can’t perform that action at this time.