Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text not marked as containing link to another page/website in XWiki PDF export #129

Closed
ane-gabriela opened this issue Apr 3, 2020 · 1 comment

Comments

@ane-gabriela
Copy link

@ane-gabriela ane-gabriela commented Apr 3, 2020

Steps to reproduce:

  1. Create a new Diagram
  2. Add some shapes
  3. Add a word in each shape
  4. Select the word from one of the shapes
  5. Click on the Link... button below Insert from the right panel
  6. Select a wiki page > Apply
  7. Select another shape/word
  8. Click on the Link... button below Insert from the right panel
  9. Select External and paste an URL eg. https://en.wikipedia.org/wiki/Flower
  10. Click Save & View
  11. Access More actions > Export > Export as PDF
  12. Deselect all options > Export

Expected results: Text is marked as containing links to internal/external pages.

Actual results: Text is not marked but when hover the links are there.

Environment: Windows 10, XWiki 11.10.4 with MySQL 5.7 and Chrome 80

ViewMode
LinkToSandbox
xwiki_Diagram_User+1+Diagram_WebHome.pdf

@oanalavinia
Copy link

@oanalavinia oanalavinia commented Apr 3, 2020

This reason for this issue is that the style of a link (underline and blue color) was not added in #101 (note that the links are working)

oanalavinia added a commit that referenced this issue Apr 3, 2020
…DF export #129

* added link decorations for marking the text as a link: blue color and underline
@oanalavinia oanalavinia self-assigned this Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants