-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't save diagrams with text inside certain shapes #144
Comments
Investigation: The issue is caused by: https://github.com/xwikisas/application-diagram/blob/master/application-diagram-ui/src/main/resources/Diagram/DiagramEditSheet.xml#L865 |
* there are shape that don't have a rect as a parent, that is needed as a frame for the wrapping process, and in this case we use the initial width of the mxText node
Reopening since the fix is not complete. Here https://github.com/xwikisas/application-diagram/blob/master/application-diagram-ui/src/main/resources/Diagram/DiagramEditSheet.xml#L876 it is not taking into consideration only the last rect parent, but any that could be found in the diagram, leading to the blocked save if you do not have any rect in the diagram, or to a wrong width, which does not correspond to the current element. |
* take into consideration only the previous element as a rect parent, otherwise any other rect will be considered as parent, leading to the blocked save if you do not have any rect in the diagram, or to a wrong width, which does not correspond to the current element.
* take into consideration only the previous element as a rect parent, otherwise any other rect will be considered as parent, leading to the blocked save if you do not have any rect in the diagram, or to a wrong width, which does not correspond to the current element.
Steps to reproduce:
Create a new diagram
Add a Diamond / Triangle/ Actor / Round (not squared) shape with text inside
Click on Save & View / Save
Expected results: The diagram is saved.
Actual results: The Save & View / Save button becomes disabled but the page remains blocked and nothing happens, the page is not saved.
The text was updated successfully, but these errors were encountered: