Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagram installation remains on hold on a XWiki Cloud instance #148

Closed
oanalavinia opened this issue May 25, 2020 · 3 comments · Fixed by #149 or #150
Closed

Diagram installation remains on hold on a XWiki Cloud instance #148

oanalavinia opened this issue May 25, 2020 · 3 comments · Fixed by #149 or #150
Assignees
@oanalavinia
Labels
Priority: Critical Type: Bug
Milestone
1.13.2

Comments

@oanalavinia
Copy link

@oanalavinia oanalavinia commented May 25, 2020

Trying to install Diagram could sometimes result in having the installation process stuck in the Extension Manager.

This was reproduced on a XWiki 11.10.4 Cloud instance with Diagram Application 1.13.1.
@oanalavinia oanalavinia added this to the 1.13.2 milestone May 25, 2020
@oanalavinia oanalavinia self-assigned this May 25, 2020
oanalavinia added a commit to oanalavinia/application-diagram that referenced this issue May 25, 2020
@oanalavinia
Diagram installation remains on hold on a XWiki Cloud instance xwikis…
5257663 
…as#148

* be sure that there are not multiple renaming jobs that are trying to start the diagram threads at once when they not initialized yet by macking this process synchronized
* verify that an entry queue added after page rename could be a needed entry by checking it has backlinks
oanalavinia added a commit that referenced this issue May 26, 2020
@oanalavinia
Diagram installation remains on hold on a XWiki Cloud instance #148
40df34c 
* synchronize the process of starting threads to be sure that there are not multiple renaming jobs trying to start the threads at once when they not initialized yet (to avoid creating multiple threads and keep only the last assignment)
* verify that an entry queue added after page rename could be a needed entry by checking it has backlinks
@oanalavinia oanalavinia linked a pull request May 26, 2020 that will close this issue
Diagram installation remains on hold on a XWiki Cloud instance #148 #149
Merged
@oanalavinia
Copy link
Author

@oanalavinia oanalavinia commented May 27, 2020

After further investigations this issue seems to be related to other causes too.

@oanalavinia oanalavinia reopened this May 27, 2020
oanalavinia added a commit to oanalavinia/application-diagram that referenced this issue May 27, 2020
@oanalavinia
Diagram installation remains on hold on a XWiki Cloud instance xwikis…
156c6ce 
…as#148

* static variable of abstract class was duplicated in child class
* changed logger method that was showing the message only on debug mode
* incorrect style on a page
oanalavinia added a commit that referenced this issue May 28, 2020
@oanalavinia
Diagram installation remains on hold on a XWiki Cloud instance #148 (#…
db20fa6 
…150)

* static variable of abstract class was duplicated in child class
* changed logger method that was showing the message only on debug mode
* incorrect style on a page
@oanalavinia oanalavinia linked a pull request May 28, 2020 that will close this issue
Diagram installation remains on hold on a XWiki Cloud instance #148 #150
Merged
@oanalavinia
Copy link
Author

@oanalavinia oanalavinia commented Jun 5, 2020

Since the bug remains in Diagram Application version 1.13.1, it could also be reproduced when upgrading from 1.13.1 to 1.13.2+ (the upgrade will remain stuck) (upgrading any older version to 1.13.2+ would not have any problems)

As an workaround, if the upgrade will remain stuck, after restarting the server a new upgrade try should work, or uninstalling 1.13.1 and installing the new version.

@oanalavinia
Copy link
Author

@oanalavinia oanalavinia commented Nov 25, 2020 •
edited

A side effect of this issue is that while having installed Diagram Application 1.13.1, other upgrades or installs of licensed applications or simply the upgrade of Licensing Application will remain on hold and a restart of the wiki will be needed (but the upgrade will be done).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oanalavinia oanalavinia

Labels
Priority: Critical Type: Bug
Projects
None yet
Milestone
1.13.2
1 participant
@oanalavinia