Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating links after renaming a page only works for the first link when the text is separated by "Enter" #151

Closed
oanalavinia opened this issue May 28, 2020 · 1 comment

Comments

@oanalavinia
Copy link

oanalavinia commented May 28, 2020

Steps to reproduce:

  1. Create a new Diagram
  2. Add a Text shape
  3. Add some text on different rows separated by enter
  4. Add links to two of the rows (the full row must be selected)
    example
  5. Click Save & View
  6. Go the second linked page and rename it
  7. Go back to the diagram and check the link

Expected results:
The second link was renamed properly

Actual results:
The link remained the same

For the first link the rename works correctly

Tested with Diagram Application 1.13.2, XWIki 11.10.4

@oanalavinia oanalavinia added this to the 1.13.3 milestone May 28, 2020
@oanalavinia
Copy link
Author

oanalavinia commented May 28, 2020

Investigation: this issue is related to the fix added by #118 and as said in #146 (comment) the problem is that we are only checking for the first link here https://github.com/xwikisas/application-diagram/blob/master/application-diagram-api/src/main/java/com/xwiki/diagram/internal/handlers/DiagramLinkHandler.java#L217

@oanalavinia oanalavinia modified the milestones: 1.13.3, 1.14.1 Jun 5, 2020
@oanalavinia oanalavinia removed this from the 1.14.1 milestone Jun 17, 2020
@oanalavinia oanalavinia self-assigned this Jul 21, 2020
oanalavinia added a commit to oanalavinia/application-diagram that referenced this issue Jul 22, 2020
…en the text is separated by "Enter" xwikisas#151

* consider that multiple links could be in the same text element
oanalavinia added a commit to oanalavinia/application-diagram that referenced this issue Jul 22, 2020
…en the text is separated by "Enter" xwikisas#151

* updated comment
oanalavinia added a commit to oanalavinia/application-diagram that referenced this issue Jul 22, 2020
oanalavinia added a commit to oanalavinia/application-diagram that referenced this issue Aug 11, 2020
oanalavinia added a commit that referenced this issue Aug 12, 2020
…en the text is separated by "Enter" #151 (#167)

* consider that multiple links could be in the same text element
@oanalavinia oanalavinia added this to the 1.15.2 milestone Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant