Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagram are not well saved when contains an Actor shape #160

Closed
CamiAndrei opened this issue Jun 15, 2020 · 1 comment
Closed

Diagram are not well saved when contains an Actor shape #160

CamiAndrei opened this issue Jun 15, 2020 · 1 comment

Comments

@CamiAndrei
Copy link

@CamiAndrei CamiAndrei commented Jun 15, 2020

Steps to reproduce this issue:

  • Insert a diagram m that doesn't exist yet in a page
    e.g.: Add in wiki mode: {{diagram reference="Diagram"/}} . "Diagram", doesn't exists.
  • Click "Save and View"
  • Click "Create diagram"
  • Add some content in the diagram with shapes, an "Actor" shape
  • Click Save&View
    Save&View it's grayed out and the page is not saved

In the browser's console log the following error message is displayed:

XML Parsing Error: unclosed token
Location: http://.......:8080/xwiki/bin/edit/Sandbox/Diagramm?template=Diagram.DiagramTemplate
Line Number 1, Column 1: Diagram:1:1
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://rt.draw.io/cache?alive. (Reason: CORS header ‘Access-Control-Allow-Origin’ missing).

TypeError: rectangles[(rectangles.length - 1)] is undefined
DiagramEditSheet:604:27

Screenshot from 2020-06-15 15-11-46

  • Click Save. The Save button it's gray-out too.
  • Click Preview
  • Then Save&View from preview.
  • Go to the page where it was inserted
    Only a link to the diagram is displayed. The diagram is not displayed.
  • Remove the "Actor" shape
    The diagram is displayed in the page where it was inserted.

Screenshot from 2020-06-15 18-26-41

Also the diagram are not updated anymore in the pages where they were inserted, if at some point an Actor shape was added in it.

  • Add an Actor shape to an existing diagram
  • Click Save&View
    Save&View it's grayed out and the page is not saved
  • Click Save. The Save button it's gray-out too.
  • Click Preview
  • Then Save&View from preview.
  • Go to the page where it was inserted
    The changes made in the diagram are not updated in the inserted page.
@CamiAndrei CamiAndrei changed the title Diagram are not well saved when contain an Actor shape Diagram are not well saved when contains an Actor shape Jun 15, 2020
@oanalavinia
Copy link

@oanalavinia oanalavinia commented Jun 16, 2020

This issue is duplicated to #144 , and as is explained in the comment #144 (comment) the issue is resumed to the problem that if the text is not inserted in a squared shape the diagram cannot be saved.
I have updated the description to specify that it includes Actor shapes as well

@oanalavinia oanalavinia self-assigned this Jun 16, 2020
@oanalavinia oanalavinia modified the milestones: 1.14.1, 1.15 Jun 16, 2020
@mflorea mflorea removed this from the 1.15 milestone Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants