Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with exporting Clipart shapes #22

Closed
ane-gabriela opened this issue Feb 26, 2019 · 9 comments
Assignees
Milestone

Comments

@ane-gabriela
Copy link

@ane-gabriela ane-gabriela commented Feb 26, 2019

Steps to reproduce:

  1. Add some Clipart shapes in a diagram
  2. Export it as PDF, HTML, XML

Expected results: The shapes added are exported and shown.

Actual results: The Clipart shapes aren't appearing.

Environment: Windows 10, XWiki 10.11.3 with MySQL 5.7 and Edge 18

htmlexportclipart
clipartdiagram
pdfexportclipart

@ane-gabriela ane-gabriela added this to the 1.6.2 milestone Feb 26, 2019
@arcilli arcilli self-assigned this Aug 14, 2019
@arcilli

This comment has been minimized.

Copy link

@arcilli arcilli commented Aug 19, 2019

Seems like the problem (or at least for HTML) is caused by bad URLs that are generated at export (a combination between draw.io & local instance of xwiki paths).

Now, depending of the use-case, would it be useful to provide a local URL (from local instance of xwiki) or URLs for draw.io hosted cliparts?
WDYT, @mflorea?

@mflorea

This comment has been minimized.

Copy link
Collaborator

@mflorea mflorea commented Aug 19, 2019

@arcilli can you post an example of an HTML export of a simple diagram with just a single clipart shape? (in order to better understand the issue). Thanks.

@arcilli

This comment has been minimized.

Copy link

@arcilli arcilli commented Aug 19, 2019

<g transformOrigin="0 0" transform="scale(1,1)translate(-102,-82)">
  <g></g>
  <g>
    <g style="visibility: visible;">
      <image x="110" y="90" width="80" height="80" style="pointer-events:none"
        xlink:href="https://www.draw.io/xwiki/webjars/wiki%3Asub/draw.io/8.9.9/img/lib/clip_art/networking/Bridge_128x128.png"></image>
      <rect visibility="hidden" pointer-events="fill" x="110" y="90" width="80" height="80"></rect>
    </g>
  </g>
  <g></g>
  <g></g>
</g>`

Same problem with broken links is present when exporting diagrams with regular images (i.e. the images that are uploaded as attachments - image src example when exporting https://www.draw.io/xwiki/wiki/sub/download/Diagram/A%20diagram/WebHome/Pim_batman-mask-clipart_273067.png). Considering that, I'm thinking more about providing links from a local instance.

@mflorea

This comment has been minimized.

Copy link
Collaborator

@mflorea mflorea commented Aug 20, 2019

Indeed, the URL

https://www.draw.io/xwiki/webjars/wiki%3Asub/draw.io/8.9.9/img/lib/clip_art/networking/Bridge_128x128.png

is wrong. We need to find the place where this URL is generated and hook our code that uses the current host instead of draw.io (like we did for the URL export).

@ilieandriuta

This comment has been minimized.

Copy link

@ilieandriuta ilieandriuta commented Aug 30, 2019

I don't know if it's the same cause, but neither JPEG files are exported in PDF (tested with Diagram Pro 1.7.1 on XWiki 11.3.3).

Diagram from XWiki page:

Diagram_from_page

Diagram exported as PDF:

Diagram_exported_PDF

Environment: Windows 10 Pro 64 bit, Chrome 76, using a local instance XWiki 11.3.3 on PostgreSQL 11

@mflorea

This comment has been minimized.

Copy link
Collaborator

@mflorea mflorea commented Sep 2, 2019

@ilieandriuta is probably referring tot the PDF export from the Diagram menu, not the XWiki page export.

@ilieandriuta

This comment has been minimized.

Copy link

@ilieandriuta ilieandriuta commented Sep 3, 2019

Yes, I was referring to JPEG files not being exported to PDF export from Diagram, basically following the Steps to reproduce listed above on this issue.

@arcilli

This comment has been minimized.

Copy link

@arcilli arcilli commented Sep 3, 2019

@ilieandriuta, seems like that issue is already presented in #61.

@arcilli arcilli removed their assignment Sep 23, 2019
@mflorea mflorea removed this from the 1.6.2 milestone Oct 9, 2019
mflorea added a commit that referenced this issue Nov 13, 2019
Issues with exporting Clipart shapes #22
* Filter the diagram XML on load / save / import / export
* Improve the SVG export (convert custom internal links to URLs and fix the foreignObject alternate text)
@mflorea mflorea self-assigned this Nov 13, 2019
@mflorea mflorea added this to the 1.11 milestone Nov 13, 2019
@mflorea mflorea closed this Nov 13, 2019
@ane-gabriela

This comment has been minimized.

Copy link
Author

@ane-gabriela ane-gabriela commented Nov 27, 2019

Export as HTML was removed - see #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.