Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagram page PDF export does not contain the diagram #29

Closed
slauriere opened this issue Mar 28, 2019 · 4 comments

Comments

@slauriere
Copy link

commented Mar 28, 2019

Steps to reproduce

  • Create a simple diagram and save it
  • Hit the button "More actions > Export > PDF"

Behaviour

  • The diagram is not present in the generated PDF, which is not expected.

Configuration

  • XWiki 11.1
  • Diagram Pro 1.6.2

@slauriere slauriere added the Type: Bug label Mar 28, 2019

@oanalavinia oanalavinia self-assigned this Jul 23, 2019

oanalavinia added a commit to oanalavinia/application-diagram that referenced this issue Jul 26, 2019
Diagram page PDF export does not contain the diagram xwikisas#29
* saved the diagram as an image that is displayed for export as pdf
@oanalavinia

This comment has been minimized.

Copy link

commented Jul 26, 2019

This issue is reproducing only for private documents (i.e. having 'Prevent unregistered users from viewing pages, regardless of the page or space rights' checked on Rights page from XWiki Preferences).
More details are also on the JIRA issue https://jira.xwiki.org/browse/XADIAGRAM-45

oanalavinia added a commit to oanalavinia/application-diagram that referenced this issue Aug 9, 2019
Diagram page PDF export does not contain the diagram xwikisas#29
* stop the default save until the upload is completed and trigger it after
oanalavinia added a commit to oanalavinia/application-diagram that referenced this issue Aug 9, 2019
oanalavinia added a commit to oanalavinia/application-diagram that referenced this issue Aug 12, 2019
Diagram page PDF export does not contain the diagram xwikisas#29
* refactor the code to have generic functions using promises
oanalavinia added a commit to oanalavinia/application-diagram that referenced this issue Aug 12, 2019
oanalavinia added a commit to oanalavinia/application-diagram that referenced this issue Aug 12, 2019
oanalavinia added a commit that referenced this issue Aug 12, 2019
Merge pull request #45 from oanalavinia/issue#29
Diagram page PDF export does not contain the diagram #29

@mflorea mflorea added this to the 1.6.6 milestone Aug 13, 2019

@oanalavinia

This comment has been minimized.

Copy link

commented Aug 14, 2019

For this fix to work after the upgrade on already finished diagrams, the user still needs to edit the diagram one more time before exporting it.

@mflorea

This comment has been minimized.

Copy link
Collaborator

commented Aug 14, 2019

@oanalavinia indeed, good point. It's not easy to write a (server-side) migration at this point because the diagram thumbnail is generated on the client side when the diagram is saved (we would have to load all the diagrams in edit mode and save them..). I think it's acceptable to ask the user to re-save the diagram if the PDF export is not good.

@oanalavinia

This comment has been minimized.

Copy link

commented Sep 11, 2019

Considering this jira issue https://jira.xwiki.org/browse/XWIKI-14204 there are some xwiki versions on which the diagram image attachment won't be added at creation step, so neither the page pdf export will work until an extra edit and save will be performed on the diagram.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.