Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF export seems to expose possibly restricted content to an external service #30

Closed
slauriere opened this issue Mar 28, 2019 · 1 comment
Assignees
Milestone

Comments

@slauriere
Copy link

@slauriere slauriere commented Mar 28, 2019

When exporting a diagram from the diagram editor (menu "File > Export as > PDF"), a request is sent to https://exp.draw.io/ – which may expose the page content to an external service without the user consent, doesn't it?

@slauriere slauriere changed the title PDF export exposes seems to expose possibly restricted content to an external service PDF export seems to expose possibly restricted content to an external service Mar 28, 2019
@mflorea mflorea added this to the 1.8 milestone Sep 11, 2019
@mflorea mflorea self-assigned this Sep 11, 2019
@mflorea mflorea modified the milestones: 1.8, 1.9 Sep 20, 2019
@mflorea mflorea modified the milestones: 1.9, 1.10, 1.11 Oct 4, 2019
mflorea added a commit that referenced this issue Oct 30, 2019
… service #30

* Add the API module in order to do the PDF export on the XWiki server
mflorea added a commit that referenced this issue Nov 1, 2019
… service #30

* First version.
mflorea added a commit that referenced this issue Nov 8, 2019
… service #30

* The data sent by the browser is compressed so we need to pre-process it before parsing.
* Refactor the code a bit in order to be able to test it more easily.
mflorea added a commit that referenced this issue Nov 15, 2019
… service #30

* Refactor the diagram editor and viewer setup in order to remove code duplication and to load the diagram application configuration from the server so that the users don't have to clear the browser cache when the configuration changes. This is required before adding the export server configuration.
mflorea added a commit that referenced this issue Nov 15, 2019
… service #30

* Add the posibility to configure another diagram export sever
mflorea added a commit that referenced this issue Nov 15, 2019
… service #30

* Add required dependency
@mflorea

This comment has been minimized.

Copy link
Collaborator

@mflorea mflorea commented Nov 15, 2019

I added a configuration section to allow using a different diagram export server. In order to setup your own export server you need to look at https://github.com/jgraph/draw-image-export2 . Docker images can be found at https://github.com/jgraph/docker-drawio .

I opened XWPLT-2913 to ask the XWiki SAS infra team to host a diagram export server for our paid customers.

@mflorea mflorea closed this Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.