Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The link to a Diagram text is not saved in view mode if you don't click outside the text element before saving the Diagram page #37

Closed
iuliabalan opened this issue May 23, 2019 · 1 comment

Comments

@iuliabalan
Copy link

commented May 23, 2019

Steps to reproduce:

  • add a diagram page, edit it and add a text
  • select the text and add a link on it.
    Expected result: when saving the diagram page you can see the link in view mode
    Actual result: if I don't click outside the text element before saving the diagram page you don't see in view mode the link (either with Admin or non-admin user).

If I click outside the text element (and the format options of text are no longer visible) and then I save the diagram page I can see the link in view mode.
I tested on XWiki version 8.4.4 with Diagram Application (Pro) 1.6.5 (I first tested with Diagram App 1.2 and reproduced the same.

Testing on draw.io online (v 10.6.8) I don't reproduce the issue, after saving the diagram page no matter if I click outside the text element or not the link is visible after saving the diagram.

@iuliabalan iuliabalan changed the title Creating a link is not saved in view mode if you don't click outside the text element before saving the diagram page The link to a Diagram text is not saved in view mode if you don't click outside the text element before saving the diagram page May 23, 2019

@iuliabalan iuliabalan changed the title The link to a Diagram text is not saved in view mode if you don't click outside the text element before saving the diagram page The link to a Diagram text is not saved in view mode if you don't click outside the text element before saving the Diagram page May 23, 2019

@iuliabalan

This comment has been minimized.

Copy link
Author

commented May 23, 2019

Link in XWiki Diagram page before and after save:
XWikiDiagrambeforeSave
XWikiDiagramAfterSave

Link in draw.io Diagram before and after save:
DrawDiagramBeforeSave
DrawDiagramAfterSave

@arcilli arcilli self-assigned this Jul 16, 2019

mflorea added a commit that referenced this issue Jul 25, 2019
Merge pull request #44 from xwikisas/issue#37
#37: The link to a Diagram text is not saved in view mode if you don't click outside the text element before saving the Diagram page

@mflorea mflorea closed this Jul 25, 2019

@mflorea mflorea added this to the 1.6.6 milestone Jul 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.