Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving the diagram takes to long after several changes made #49

Closed
oanalavinia opened this issue Aug 13, 2019 · 1 comment

Comments

@oanalavinia
Copy link

commented Aug 13, 2019

Steps to reproduce

  1. Create a simple diagram
  2. Edit and save it several times (i.e. 50)
  3. Observe the save process for last attempts

Expected result
The save is made immediately.

Actual result
It takes ~2 seconds until the 'Save' notification appears, meaning also until the changes were saved, which is way to much.

Environment
XWiki 8.4, Chromium 71.0.3

@oanalavinia

This comment has been minimized.

Copy link
Author

commented Aug 13, 2019

This issue was introduced after the fix for #29, which introduces the save of the diagram as an image attachment, that is to be used at the export step. After several changes made, updating the version of the attachment is causing the delay.

oanalavinia added a commit to oanalavinia/application-diagram that referenced this issue Aug 19, 2019
Saving the diagram takes to long after several changes made xwikisas#49
* for not having to many versions upload the attachment only after the delete of the existing one is finished, even if it was succeded or not
* an error could appear in the developer console if the attachment didn't existed on the page, without altering the functionalities
oanalavinia added a commit to oanalavinia/application-diagram that referenced this issue Aug 19, 2019
oanalavinia added a commit to oanalavinia/application-diagram that referenced this issue Aug 19, 2019
oanalavinia added a commit to oanalavinia/application-diagram that referenced this issue Aug 20, 2019
oanalavinia added a commit that referenced this issue Aug 21, 2019
Merge pull request #51 from oanalavinia/issue#49
Saving the diagram takes to long after several changes made #49

@oanalavinia oanalavinia added this to the 1.7 milestone Aug 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.