Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF export from wiki page menu not working if diagram page doesn't have attachment #84

Closed
AndreeaChi opened this issue Nov 1, 2019 · 3 comments
Assignees
Milestone

Comments

@AndreeaChi
Copy link

@AndreeaChi AndreeaChi commented Nov 1, 2019

When trying to export a diagram that doesn't have a file in the attachments section, the PDF exported from the wiki page menu does not include the diagram.

Tested on Chrome, Version 77.0, Windows 10 Pro

Current workaround was to add a modification to the diagram and then to save it in order to have an attachment appear in the dedicated section and to be able to see the diagram in a PDF export.

image

@mflorea

This comment has been minimized.

Copy link
Collaborator

@mflorea mflorea commented Nov 4, 2019

This actually happens on closed wikis only. On open wikis, when the image attachment is missing the export falls-back on the SVG export, which is not perfect, but the diagram should appear.

@oanalavinia

This comment has been minimized.

Copy link

@oanalavinia oanalavinia commented Nov 7, 2019

More details from the wider issue #29. On this comment #29 (comment) it is specified that the fix is working only with an extra editing (changes + save) step for diagrams created before 1.7

mflorea added a commit that referenced this issue Nov 14, 2019
…ve attachment #84

* Generate only the SVG image on save and store it as an attachment instead of using an object property
* Use the svg attachment for PDF export.
@mflorea mflorea self-assigned this Nov 14, 2019
@mflorea mflorea added this to the 1.11 milestone Nov 14, 2019
mflorea added a commit that referenced this issue Nov 18, 2019
…ve attachment #84

* Add migration to move the diagram SVG from the diagram xobject to the diagram.svg attachment on the same page.
@mflorea

This comment has been minimized.

Copy link
Collaborator

@mflorea mflorea commented Nov 18, 2019

The diagram SVG has been moved from the diagram object to an attachment named diagram.svg which is always generated by the application (IE included). Existing diagrams are migrated when the Diagram Application is upgraded. If you delete the diagram.svg attachment by mistake then you need to edit and save the diagram page in order to regenerate it.

@mflorea mflorea closed this Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.